-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecate Python 3.7 #19017
chore: Deprecate Python 3.7 #19017
Conversation
f3174f9
to
42678bd
Compare
@@ -80,7 +80,7 @@ jobs: | |||
runs-on: ubuntu-20.04 | |||
strategy: | |||
matrix: | |||
python-version: [3.8, 3.9] | |||
python-version: ["3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without quotes, YAML interprets 3.10
as a number i.e., 3.1
and thus I felt it was prudent to explicitly define all versions as strings and not numbers.
42678bd
to
a60537a
Compare
a60537a
to
b68b92c
Compare
requirements/base.txt
Outdated
@@ -162,7 +162,7 @@ multidict==5.1.0 | |||
# via | |||
# aiohttp | |||
# yarl | |||
numpy==1.21.1 | |||
numpy==1.22.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needed to be bumped to resolve numpy/numpy#19033. Note this was bumped by deleting lines 165–168 and running pip-compile-multi --no-upgrade
.
b68b92c
to
21e2fcf
Compare
21e2fcf
to
6fc879e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! Can you also update the docs to reflect this (remove the reference to 3.7 and add 3.9): https://github.com/apache/superset/blob/master/docs/docs/contributing/local-backend.mdx
Codecov Report
@@ Coverage Diff @@
## master #19017 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1645 1645
Lines 63515 63515
Branches 6464 6464
=======================================
Hits 42250 42250
Misses 19593 19593
Partials 1672 1672
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@villebro I've addressed your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
SUMMARY
As titled.
Note as part of this PR I tried to add support for 3.10 however this is more work, i.e., beyond bumping
numpy
we would also need to relax the constraints for a number of packages defined insetup.py
, i.e., the current version bound forpyarrow
,sqlalchemy
, etc. do not support Python 3.10.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION