Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal #18786

Merged

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Feb 17, 2022

SUMMARY

the contrast on the help text doesn't seem to meet accessibility reqs

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #18786 (af9d035) into master (5bb406b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18786      +/-   ##
==========================================
- Coverage   66.32%   66.31%   -0.01%     
==========================================
  Files        1620     1620              
  Lines       63060    63086      +26     
  Branches     6368     6372       +4     
==========================================
+ Hits        41823    41837      +14     
- Misses      19579    19592      +13     
+ Partials     1658     1657       -1     
Flag Coverage Δ
javascript 51.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/DeleteModal/index.tsx 84.21% <100.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 40.86% <0.00%> (-10.76%) ⬇️
...perset-frontend/src/views/components/MenuRight.tsx 80.00% <0.00%> (-0.49%) ⬇️
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <0.00%> (ø)
superset-frontend/src/components/ListView/utils.ts 77.41% <0.00%> (ø)
...rontend/src/components/ListView/Filters/Search.tsx 78.57% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <0.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 69.82% <0.00%> (ø)
...ontend/src/explore/components/QueryAndSaveBtns.jsx
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb406b...af9d035. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.87.138.9:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

Thanks for this... I just made it one shade lighter which passes accessibility standards, but still has some contrast with the text above it.
image

@rusackas rusackas merged commit 2d67d2f into apache:master Feb 17, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants