Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sqllab schema select error msg #18564

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Feb 3, 2022

SUMMARY

This pr fixes and issue where if the sqllab backend persistence flag is on the param being passed into the dispatch function is not always a object and will subsequently caused the call to fail.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2022-02-02 at 9 33 35 PM

after

Screen.Recording.2022-02-02.at.9.29.30.PM.mov

TESTING INSTRUCTIONS

Go to sql lab and click the schema and database selects. The error toast should not show.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, I just bumped into this the other day!

superset-frontend/src/SqlLab/actions/sqlLab.js Outdated Show resolved Hide resolved
superset-frontend/src/SqlLab/actions/sqlLab.js Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #18564 (5572efa) into master (9c3205b) will increase coverage by 0.01%.
The diff coverage is 25.00%.

❗ Current head 5572efa differs from pull request most recent head 7c84de3. Consider uploading reports for the commit 7c84de3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18564      +/-   ##
==========================================
+ Coverage   66.27%   66.29%   +0.01%     
==========================================
  Files        1594     1594              
  Lines       62621    62623       +2     
  Branches     6311     6312       +1     
==========================================
+ Hits        41505    41518      +13     
+ Misses      19467    19456      -11     
  Partials     1649     1649              
Flag Coverage Δ
javascript 51.34% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 52.23% <0.00%> (-0.30%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <100.00%> (ø)
superset/views/core.py 77.59% <0.00%> (+0.44%) ⬆️
superset/models/core.py 89.10% <0.00%> (+0.72%) ⬆️
superset/db_engine_specs/mysql.py 97.59% <0.00%> (+3.61%) ⬆️
superset/common/utils/dataframe_utils.py 92.85% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3205b...7c84de3. Read the comment docs.

@pkdotson pkdotson merged commit 151d30b into apache:master Feb 4, 2022
@rosemarie-chiu
Copy link
Contributor

🏷 preset:2022.5

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 7, 2022
* fix: sqllab schema select error msg

* remove console logs

* fix lint

(cherry picked from commit 151d30b)
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* fix: sqllab schema select error msg

* remove console logs

* fix lint
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
* fix: sqllab schema select error msg

* remove console logs

* fix lint
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* fix: sqllab schema select error msg

* remove console logs

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.5 preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants