Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(teradata): LIMIT syntax #18240

Merged
merged 42 commits into from
Feb 1, 2022
Merged

fix(teradata): LIMIT syntax #18240

merged 42 commits into from
Feb 1, 2022
+338 −25

Conversation

dmcnulla
Copy link
Contributor

@dmcnulla dmcnulla commented Feb 1, 2022 •
edited by nytai
Loading

This PR is a continuation of #15930, all of the context is there.

mccushjack and others added 30 commits June 9, 2021 17:12
@mccushjack
temp not working
9a37eb7
@mccushjack
Merge branch 'apache:master' into master
873fc7b
@mccushjack
Update sql_parse.py
c54a606 
updates to set_or_update_query_limit_top
@mccushjack
fix for apply limit for Teradata connections
f3e808f 
adding apply_limit_to_sql and get_dbapi_mapped_exception
@mccushjack
Merge branch 'apache:master' into master
8a5ca7b
@mccushjack
Merge branch 'apache:master' into master
d9e89b2
@mccushjack
fixes to teradata driver and limit methods in teradata.py
0f34db8
@mccushjack
Merge branch 'apache:master' into master
9e7def5
@mccushjack
remove logging to tdpy
252987e
@mccushjack
Merge branch 'master' of github.com:mccushjack/superset
ed72dd6 
rebase
@mccushjack
rebase for Teradata fixes
22030d0 
rebase for Teradata fixes for merge for 15930
@mccushjack
rebase for TD fixes
bba1b13 
rebase for issue 15930 and update to new Teradata driver
@mccushjack
Merge remote-tracking branch 'upstream/master'
cf92a6e
@mccushjack
Update teradata.py
830ca55
@mccushjack
fixes to td.py table ref4
c4a4898
@mccushjack @betodealmeida
Update superset/db_engine_specs/teradata.py
21a1de5 
Co-authored-by: Beto Dealmeida <[email protected]>
@mccushjack @betodealmeida
Update superset/db_engine_specs/teradata.py
21db8dd 
Co-authored-by: Beto Dealmeida <[email protected]>
@mccushjack @betodealmeida
Update superset/db_engine_specs/teradata.py
7535758 
Co-authored-by: Beto Dealmeida <[email protected]>
@mccushjack @betodealmeida
Update superset/db_engine_specs/teradata.py
3f887e9 
Co-authored-by: Beto Dealmeida <[email protected]>
@mccushjack @betodealmeida
Update superset/db_engine_specs/teradata.py
2aae450 
Co-authored-by: Beto Dealmeida <[email protected]>
@mccushjack @betodealmeida
Update tests/unit_tests/db_engine_specs/test_teradata.py
f4ef16a 
Co-authored-by: Beto Dealmeida <[email protected]>
@mccushjack @betodealmeida
Update superset/db_engine_specs/teradata.py
2fcd27c 
Co-authored-by: Beto Dealmeida <[email protected]>
@mccushjack
Update teradata.py
13228c5
@mccushjack
Update teradata.py
a4fead1
@mccushjack
Update test_teradata.py
2075f83
@mccushjack
Update test_teradata.py
0984e03
@nytai
Merge branch 'master' into master
c3dc448
commit updates
c6b8e9c
@mccushjack
Merge remote-tracking branch 'upstream/master'
67d89ec
improve insert, make sure it is right after SEL keyword
ea9c3bd
@nytai nytai changed the title Fix unit fix(teradata): LIMIT syntax Feb 1, 2022
@nytai
Copy link
Member

nytai commented Feb 1, 2022

this looks like the one!

nytai
nytai approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on #15930

@codecov
Copy link

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #18240 (3216e6a) into master (4ad5ad0) will increase coverage by 0.02%.
The diff coverage is 61.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18240      +/-   ##
==========================================
+ Coverage   66.04%   66.06%   +0.02%     
==========================================
  Files        1591     1591              
  Lines       62398    62547     +149     
  Branches     6283     6283              
==========================================
+ Hits        41210    41324     +114     
- Misses      19567    19602      +35     
  Partials     1621     1621
Flag Coverage Δ
hive 52.13% <19.11%> (-0.05%) ⬇️
mysql 81.25% <61.02%> (-0.03%) ⬇️
postgres 81.29% <61.02%> (-0.03%) ⬇️
presto 51.97% <19.11%> (-0.05%) ⬇️
python 81.73% <61.02%> (-0.03%) ⬇️
sqlite 80.99% <61.02%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/teradata.py 62.75% <61.02%> (-27.25%) ⬇️
superset/views/base_api.py 97.89% <0.00%> (-0.33%) ⬇️
superset/views/core.py 77.59% <0.00%> (-0.15%) ⬇️
superset/constants.py 100.00% <0.00%> (ø)
superset/utils/urls.py 100.00% <0.00%> (ø)
superset/views/utils.py 82.20% <0.00%> (ø)
superset/connectors/druid/models.py 82.99% <0.00%> (ø)
superset/reports/notifications/email.py 100.00% <0.00%> (ø)
superset/queries/saved_queries/api.py 95.28% <0.00%> (+0.04%) ⬆️
superset/connectors/sqla/models.py 88.51% <0.00%> (+0.08%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad5ad0...3216e6a. Read the comment docs.

@nytai nytai merged commit 8c37654 into apache:master Feb 1, 2022
@nytai nytai mentioned this pull request Feb 1, 2022
Closed
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@dmcnulla @mccushjack
@betodealmeida @shcoderAlex
fix(teradata): LIMIT syntax (apache#18240)
5520a4f 
Co-authored-by: Mccush, Jack <[email protected]>
Co-authored-by: Jack McCush <[email protected]>
Co-authored-by: Beto Dealmeida <[email protected]>
Co-authored-by: David McNulla <[email protected]>
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
@dmcnulla @mccushjack
@betodealmeida @ofekisr
fix(teradata): LIMIT syntax (apache#18240)
ef43cba 
Co-authored-by: Mccush, Jack <[email protected]>
Co-authored-by: Jack McCush <[email protected]>
Co-authored-by: Beto Dealmeida <[email protected]>
Co-authored-by: David McNulla <[email protected]>
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@dmcnulla @mccushjack
@betodealmeida @bwang221
fix(teradata): LIMIT syntax (apache#18240)
0b59ff3 
Co-authored-by: Mccush, Jack <[email protected]>
Co-authored-by: Jack McCush <[email protected]>
Co-authored-by: Beto Dealmeida <[email protected]>
Co-authored-by: David McNulla <[email protected]>
@villebro villebro mentioned this pull request Feb 18, 2022
Merged
9 tasks
@episkey24
Copy link

Hey, I'm still facing this error with the latest version of Superset. I've installed the sqlalchemy-teradata and the ODBC drivers. The connection seems to be working fine but this LIMIT keyword syntax error in SQL editor is still coming.
Is there a step I'm missing here?
@villebro @dmcnulla @mccushjack @betodealmeida @nytai

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmcnulla @nytai @episkey24 @mccushjack @mistercrunch