refactor: move superset-ui dependencies to peerDependencies #17965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
force-pushed
the
fix_release_workflow
branch
from
bb93b00
to
72a985a
Compare
zhaoyongjie
commented
Jan 7, 2022
| "plugins:create-conventional-version": "npm run prune && lerna version --conventional-commits --create-release github --yes", | ||
| "plugins:create-minor-version": "npm run prune && lerna version minor --yes", | ||
| "plugins:create-patch-version": "npm run prune && lerna version patch --yes", | ||
| "plugins:create-conventional-version": "npm run prune && lerna version --conventional-commits --create-release github --no-private --yes", |
There was a problem hiding this comment.
do not change version of private package: superset-ui-demo
Codecov Report
@@ Coverage Diff @@
## master #17965 +/- ##
=======================================
Coverage 67.10% 67.10%
=======================================
Files 1612 1612
Lines 64992 64992
Branches 6871 6871
=======================================
Hits 43615 43615
Misses 19510 19510
Partials 1867 1867
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
zhaoyongjie
force-pushed
the
fix_release_workflow
branch
2 times, most recently
from
12ea51f
to
6e72879
Compare
zhaoyongjie
force-pushed
the
fix_release_workflow
branch
from
6e72879
to
ddd5a4e
Compare
rusackas
approved these changes
Jan 11, 2022
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…7965) * chore: add commit message * update learn * update superset-ui-demo * move superset-ui into peerDeps * add --no-private argument in lerna version * fix conflicts * refresh lock file
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…7965) * chore: add commit message * update learn * update superset-ui-demo * move superset-ui into peerDeps * add --no-private argument in lerna version * fix conflicts * refresh lock file
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In order to publish plugins to
npmregistry, this PR make:lerna.jsonlernafrom3.22.1to4.0.0(latest version)@superset-ui/pluginsfromdependenciestopeerDependenciesin eachpackages.jsonof pluginsWhy do we use
matches any versioninstead ofexact version?If we use
exact version,lerna versioncommand will update dependency to a new version that doesn't exist in the npm registry. CI will fail.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION