-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jinja): improve url parameter formatting #16711
Conversation
f94cdfa
to
c7fbe85
Compare
Codecov Report
@@ Coverage Diff @@
## master #16711 +/- ##
==========================================
- Coverage 76.93% 76.73% -0.20%
==========================================
Files 1007 1007
Lines 54146 54152 +6
Branches 7369 7369
==========================================
- Hits 41655 41552 -103
- Misses 12251 12360 +109
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
340d87d
to
5be48ce
Compare
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test (cherry picked from commit 88c09c2)
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test
SUMMARY
Add handling of special characters to URL param function in Jinja context to improve cross-database filter clause compatibility. This is done by adding the parameter
escape_result
to theurl_param
function which defaults toTrue
. When enabled, it escapes the value of the requested url param using the relevant SQLAlchemy dialect for the selected database.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION