fix: catch exception when create connection#16692
Merged
zhaoyongjie merged 3 commits intoapache:masterfrom Sep 16, 2021
Merged
Conversation
ad1ba18 to
faed3b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #16692 +/- ##
==========================================
- Coverage 76.93% 76.86% -0.08%
==========================================
Files 1007 1007
Lines 54112 54141 +29
Branches 7346 7374 +28
==========================================
- Hits 41633 41614 -19
- Misses 12239 12287 +48
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a79a552 to
4386f43
Compare
villebro
reviewed
Sep 15, 2021
cafbca6 to
00da822
Compare
villebro
pushed a commit
that referenced
this pull request
Sep 22, 2021
* fix: catch exception when create connection * fix lint * added UT (cherry picked from commit 21f98dd)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: catch exception when create connection * fix lint * added UT
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix: catch exception when create connection * fix lint * added UT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
In Google bigquery, if credential is not set, it will raise a
DefaultCredentialsError, I guess different dialects, will have some custom error types, so here to catch all errors.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:

TESTING INSTRUCTIONS
ADDITIONAL INFORMATION