Skip to content

chore: Select component refactoring - SaveModal - Iteration 5 #16446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
geido merged 14 commits into from
Sep 27, 2021
Merged

chore: Select component refactoring - SaveModal - Iteration 5 #16446

geido merged 14 commits into from
Sep 27, 2021

Conversation

@geido
Copy link
Member

@geido geido commented Aug 25, 2021 •
edited
Loading

SUMMARY

It replaces the react-select Select component with the Antdesign one in the SaveModal component.

BEFORE

save_before.mp4

AFTER

save_after.mp4

TESTING INSTRUCTIONS

  1. Open a Chart in Explore
  2. Click on Save
  3. Save the Chart in an existing Dashboard or create a new one

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido added the risk:refactor High risk as it involves large refactoring work label Aug 25, 2021
@geido
Copy link
Member Author

geido commented Aug 25, 2021

@rosemarie-chiu @jinghua-qa

@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #16446 (151e087) into master (836b5e2) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16446      +/-   ##
==========================================
- Coverage   76.89%   76.74%   -0.15%     
==========================================
  Files        1007     1007              
  Lines       54163    54161       -2     
  Branches     7463     7462       -1     
==========================================
- Hits        41647    41567      -80     
- Misses      12276    12354      +78     
  Partials      240      240
Flag Coverage Δ
hive ?
javascript 71.29% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/explore/components/SaveModal.tsx 86.81% <100.00%> (-0.29%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-1.05%) ⬇️
...rontend/src/components/Select/DeprecatedSelect.tsx 81.37% <0.00%> (-0.99%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 86.31% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.76% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836b5e2...151e087. Read the comment docs.

@junlincc junlincc added request:qa-review Requests a QA review test_priority:high and removed request:qa-review Requests a QA review labels Aug 25, 2021
michael-s-molina
michael-s-molina reviewed Aug 25, 2021
View reviewed changes
@geido geido added the hold:testing! On hold for testing label Aug 31, 2021
@geido geido removed the hold:testing! On hold for testing label Sep 16, 2021
michael-s-molina
michael-s-molina approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can we get QA approval?

superset-frontend/src/components/Select/Select.tsx Outdated
]);
}
}

Copy link
Member

@michael-s-molina michael-s-molina Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert?

@geido geido merged commit 271ec6e into apache:master Sep 27, 2021
@geido geido deleted the chore/select-component-refactoring-savemodal-iteration-5 branch September 27, 2021 15:15
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@geido
chore: Select component refactoring - SaveModal - Iteration 5 (apache…
adae67a 
…#16446)

* Refactor Select

* Fix Cypress

* Reconcile with master

* Use onChange over onSelect

* Reconcile with latest changes

* Update Cypress

* Update Cypress test

* Fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@geido
chore: Select component refactoring - SaveModal - Iteration 5 (apache…
a5eeba9 
…#16446)

* Refactor Select

* Fix Cypress

* Reconcile with master

* Use onChange over onSelect

* Reconcile with latest changes

* Update Cypress

* Update Cypress test

* Fix lint
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Jun 28, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Nov 27, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Jan 6, 2024
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@junlincc junlincc Awaiting requested review from junlincc

@kgabryje kgabryje Awaiting requested review from kgabryje

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@villebro villebro Awaiting requested review from villebro

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

@etr2460 etr2460 Awaiting requested review from etr2460

@ktmud ktmud Awaiting requested review from ktmud

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:refactor High risk as it involves large refactoring work size/M test_priority:high 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geido @michael-s-molina @mistercrunch @junlincc