fix: Render value immediately on SQL Editor for Calculated Columns in Edit Dataset modal#15820
Merged
pkdotson merged 1 commit intoapache:masterfrom Jul 22, 2021
geido:fix/issue_15675
Merged
fix: Render value immediately on SQL Editor for Calculated Columns in Edit Dataset modal#15820pkdotson merged 1 commit intoapache:masterfrom geido:fix/issue_15675
pkdotson merged 1 commit intoapache:masterfrom
geido:fix/issue_15675
Conversation
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #15820 +/- ##
==========================================
- Coverage 77.05% 77.05% -0.01%
==========================================
Files 984 984
Lines 51650 51654 +4
Branches 6991 6991
==========================================
+ Hits 39801 39804 +3
- Misses 11625 11626 +1
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
Author
|
/testenv up |
Contributor
|
@geido Ephemeral environment spinning up at http://34.215.23.49:8080. Credentials are |
rosemarie-chiu
approved these changes
Jul 21, 2021
Member
|
@geido thanks for fixing the issue and spinning up the testenv for the team 🙏 LGTM ✅ Screen.Recording.2021-07-21.at.2.34.39.PM.movBefore Screen.Recording.2021-07-21.at.2.34.04.PM.mov |
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
Contributor
|
🏷 2021.29 |
3 tasks
3 tasks
9 tasks
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


SUMMARY
It renders the typed value immediately to avoid a glitch with the cursor moving backward. It would also avoid delays with rendering the value while typing.
Fixes: #15675
Fixes: #13251
BEFORE
AFTER
DEV.Games.1.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION