refactor: refactor Icon to Icons in sqlEditor component #14463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14463 +/- ##
=======================================
Coverage 77.40% 77.40%
=======================================
Files 969 969
Lines 50013 50015 +2
Branches 6431 6431
=======================================
+ Hits 38712 38714 +2
Misses 11098 11098
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
geido
reviewed
May 6, 2021
8 tasks
Member
|
/testenv up |
Contributor
|
@rusackas Ephemeral environment spinning up at http://54.218.200.160:8080. Credentials are |
michael-s-molina
approved these changes
Jun 16, 2021
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* add triangle-down * lint fix * add suggestions
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* add triangle-down * lint fix * add suggestions
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* add triangle-down * lint fix * add suggestions
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TEST PLAN
ADDITIONAL INFORMATION