Get pivot table working in explore v2 #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get pivot_table viz working
11 tasks
ascott
reviewed
Oct 27, 2016
| // finished rendering callback | ||
| }, | ||
|
|
||
| error: () => { |
There was a problem hiding this comment.
when does this get called? should we surface an error to the user at this point? how are we currently handling this?
Contributor
Author
There was a problem hiding this comment.
this is called when getJSON failed for json endpoint in pivot_table.js, I copied some lines from our original error callback function and added them to new commit :)
ascott
reviewed
Oct 27, 2016
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| selector: `#${this.props.sliceContainerId}`, |
There was a problem hiding this comment.
looks like this is the same change as in https://github.com/airbnb/caravel/pull/1443/files
Contributor
Author
There was a problem hiding this comment.
sorry I created the world_map branch on top of this branch since there are some functions needed from here. I'll merge this first then rebase on the world_map one
|
LGTM |
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* fix: lerna can't update package-lock.json * upgrade commit message
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* fix: lerna can't update package-lock.json * upgrade commit message
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* fix: lerna can't update package-lock.json * upgrade commit message
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* fix: lerna can't update package-lock.json * upgrade commit message
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously pivot table viz was broken in explore v2
Fixed:
Added jquery calls for html() and find() in container of mock slice object
Before (pivot table in explorev2):
After:
@ascott