refactor: Boostrap to AntD - Tabs #14048

michael-s-molina · 2021-04-09T12:17:32Z

SUMMARY

Migrates remaining TabContainer, TabPanel and TabContent components from Bootstrap to AntD
Improves the storybook to support interactive controls

@villebro I'm tagging you also because of the changes in DashboardContainer. Can you help with the review? I'll add some comments to the code to provide more context.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

These are the impacted screens. No perceived difference after the changes.

TEST PLAN

1 - Access different dashboard layouts, with different tab levels
2 - Check that all layouts are working

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

michael-s-molina · 2021-04-09T12:21:01Z

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx

handleChangeTab was never called during runtime and the function interfaces were not compatible:
TabContainer.onSelect does not provide pathToTabIndex to (event: SyntheticEvent<TabContainer, Event>) => void

michael-s-molina · 2021-04-09T12:22:32Z

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx

Tabs.TabPane uses the key as the eventKey

michael-s-molina · 2021-04-09T12:24:46Z

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx

Ensures that the key of the first element is always DASHBOARD_GRID_ID to avoid expensive mounts/unmounts of the entire dashboard.

codecov · 2021-04-09T12:51:13Z

Codecov Report

Merging #14048 (ec7c42d) into master (20ab086) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head ec7c42d differs from pull request most recent head 2480a50. Consider uploading reports for the commit 2480a50 to get more accurate results

@@            Coverage Diff             @@
##           master   #14048      +/-   ##
==========================================
- Coverage   77.15%   77.04%   -0.11%     
==========================================
  Files         954      946       -8     
  Lines       48189    47987     -202     
  Branches     6002     5963      -39     
==========================================
- Hits        37180    36972     -208     
- Misses      10812    10814       +2     
- Partials      197      201       +4

Flag	Coverage Δ
javascript	`72.15% <100.00%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx	`88.37% <ø> (ø)`
...erset-frontend/src/common/components/Tabs/Tabs.tsx	`96.87% <100.00%> (ø)`
...components/DashboardBuilder/DashboardContainer.tsx	`100.00% <100.00%> (ø)`
superset/utils/dashboard_import_export.py	`0.00% <0.00%> (-100.00%)`	⬇️
superset/utils/hashing.py	`75.00% <0.00%> (-25.00%)`	⬇️
superset/cli.py	`33.66% <0.00%> (-17.33%)`	⬇️
...nts/controls/DateFilterControl/DateFilterLabel.tsx	`73.94% <0.00%> (-9.11%)`	⬇️
...nd/src/dashboard/components/FiltersBadge/index.tsx	`96.00% <0.00%> (-4.00%)`	⬇️
superset/models/dashboard.py	`74.42% <0.00%> (-3.10%)`	⬇️
...ontrols/FilterControl/AdhocFilterControl/index.jsx	`54.61% <0.00%> (-3.08%)`	⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ab086...2480a50. Read the comment docs.

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx

pkdotson · 2021-04-27T03:38:17Z

/testenv up

github-actions · 2021-04-27T03:40:27Z

@pkdotson Ephemeral environment spinning up at http://18.236.152.187:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

pkdotson

LGTM, left a comment in the discussion that's already open but should not be blocker.

villebro

LGTM and tested locally to work very well - love the new top level tab transition effect!

rusackas

LGTM too. 🚀

github-actions · 2021-04-29T06:50:13Z

Ephemeral environment shutdown and build artifacts deleted.

* master: (38 commits) refactor(native-filters): allow cascading only for filter_select (apache#14441) test(maximize-chart): Add tests to maximize chart action (apache#14371) fix: fixing mysql error message (apache#14416) feat: Logic added to limiting factor column in Query model (apache#13521) change relationship (apache#14435) fix: bootstrap data permissions (apache#14348) fix: parse simple string error message values (apache#14360) chore: add stack trace to all calls of logger.error (apache#14382) update README with new docs and recordings (apache#14432) Renamed impyla from implya in impala.mdx and Renamed PIP package impyla from impala in index.mdx (apache#14425) fix(native-filters): fix filter scope error (apache#14426) feat: Adding limiting_factor column to Query model (apache#14234) feat: Add etag caching to dashboard APIs (apache#14357) chore: Moves Card to the components folder (apache#14139) feat: Dynamic imports for the Icons component (apache#14318) feat: Support env vars configuration for WebSocket server (apache#14398) fix: SQLLab role permissions (apache#14372) fix(native-filters): always show filters without dataset (apache#14409) fix error getting partitionQuery from table.partition (apache#14369) refactor: Boostrap to AntD - Tabs (apache#14048) ...

superset-github-bot bot added the Turing label Apr 9, 2021

pull-request-size bot added the size/L label Apr 9, 2021

michael-s-molina commented Apr 9, 2021

View reviewed changes

michael-s-molina force-pushed the bootstrap-to-antd-tabs branch from 5cd628d to 01722fe Compare April 9, 2021 12:29

michael-s-molina force-pushed the bootstrap-to-antd-tabs branch from 01722fe to 9c7f8ab Compare April 9, 2021 14:28

junlincc added the frontend:refactor Related to refactoring the frontend label Apr 15, 2021

michael-s-molina force-pushed the bootstrap-to-antd-tabs branch 3 times, most recently from e64b4fa to f5e1f00 Compare April 20, 2021 14:44

geido reviewed Apr 20, 2021

View reviewed changes

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx Outdated Show resolved Hide resolved

michael-s-molina force-pushed the bootstrap-to-antd-tabs branch from f5e1f00 to 6dd3538 Compare April 26, 2021 11:15

pkdotson requested a review from villebro April 27, 2021 04:34

pkdotson approved these changes Apr 27, 2021

View reviewed changes

michael-s-molina force-pushed the bootstrap-to-antd-tabs branch from 6dd3538 to ccec4ab Compare April 27, 2021 11:33

refactor: Boostrap to AntD - Tabs

2480a50

michael-s-molina force-pushed the bootstrap-to-antd-tabs branch from ccec4ab to 2480a50 Compare April 27, 2021 11:41

villebro approved these changes Apr 29, 2021

View reviewed changes

rusackas approved these changes Apr 29, 2021

View reviewed changes

rusackas merged commit 1d6a746 into apache:master Apr 29, 2021

ktmud mentioned this pull request May 4, 2021

[Explore] Tab Animation on Metric popover flies out of the box #14475

Closed

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021

refactor: Boostrap to AntD - Tabs (apache#14048)

97deec2

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Boostrap to AntD - Tabs #14048

refactor: Boostrap to AntD - Tabs #14048

Uh oh!

michael-s-molina commented Apr 9, 2021 •

edited

Loading

Uh oh!

michael-s-molina Apr 9, 2021 •

edited

Loading

Uh oh!

michael-s-molina Apr 9, 2021

Uh oh!

michael-s-molina Apr 9, 2021

Uh oh!

codecov bot commented Apr 9, 2021 •

edited

Loading

Uh oh!

Uh oh!

pkdotson commented Apr 27, 2021

Uh oh!

github-actions bot commented Apr 27, 2021

Uh oh!

pkdotson left a comment

Uh oh!

villebro left a comment

Uh oh!

rusackas left a comment

Uh oh!

github-actions bot commented Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

refactor: Boostrap to AntD - Tabs #14048

refactor: Boostrap to AntD - Tabs #14048

Uh oh!

Conversation

michael-s-molina commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

Uh oh!

michael-s-molina Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-s-molina Apr 9, 2021

Choose a reason for hiding this comment

Uh oh!

michael-s-molina Apr 9, 2021

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

pkdotson commented Apr 27, 2021

Uh oh!

github-actions bot commented Apr 27, 2021

Uh oh!

pkdotson left a comment

Choose a reason for hiding this comment

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

michael-s-molina commented Apr 9, 2021 •

edited

Loading

michael-s-molina Apr 9, 2021 •

edited

Loading

codecov bot commented Apr 9, 2021 •

edited

Loading