Skip to content

fix: Floating Menu in SQL Left Bar #13858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
betodealmeida merged 22 commits into from
Apr 5, 2021
Merged

fix: Floating Menu in SQL Left Bar #13858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ba12aec
floating table git issue
AAfghahi Mar 29, 2021
c11a62e
made changes
AAfghahi Mar 30, 2021
ba9c017
floating table git issue
AAfghahi Mar 29, 2021
6cdcddd
made changes
AAfghahi Mar 30, 2021
2800904
long table names
AAfghahi Apr 1, 2021
6825d52
Merge branch 'master' into floatingTable
AAfghahi Apr 1, 2021
8a965e0
floating table git issue
AAfghahi Mar 29, 2021
3287cff
made changes
AAfghahi Mar 30, 2021
544ecce
floating table git issue
AAfghahi Mar 29, 2021
e21fc57
made changes
AAfghahi Mar 30, 2021
b43bdad
long table names
AAfghahi Apr 1, 2021
6e7d62f
floating table git issue
AAfghahi Mar 29, 2021
2b65adb
made changes
AAfghahi Mar 30, 2021
e23fa0e
floating table git issue
AAfghahi Mar 29, 2021
3c76671
made changes
AAfghahi Mar 30, 2021
e439b48
long table names
AAfghahi Apr 1, 2021
992837c
table values
AAfghahi Apr 2, 2021
b49e72e
aligned
AAfghahi Apr 2, 2021
ed8639b
active key
AAfghahi Apr 2, 2021
18e488b
changed to customStyle
AAfghahi Apr 2, 2021
017aac3
update dropdown styles
eschutho Apr 3, 2021
ee5ea3a
changes to z-index
AAfghahi Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe('DatasourceEditor', () => {
});

it('renders Tabs', () => {
expect(wrapper.find(Tabs)).toExist();
expect(wrapper.find('#table-tabs')).toExist();
});

it('makes an async request', () =>
Expand Down
1 change: 1 addition & 0 deletions superset-frontend/src/SqlLab/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ div.Workspace {
.schemaPane-enter-done,
.schemaPane-exit {
transform: translateX(0);
z-index: 1020;
Copy link
Contributor

@maltoze maltoze Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

@AAfghahi AAfghahi Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13972

}

.schemaPane-exit-active {
Expand Down
11 changes: 9 additions & 2 deletions superset-frontend/src/datasource/DatasourceEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@ const FlexRowContainer = styled.div`
}
`;

const StyledTableTabs = styled(Tabs)`
overflow: visible;
.ant-tabs-content-holder {
overflow: visible;
}
`;

const EditLockContainer = styled.div`
font-size: ${supersetTheme.typography.sizes.s}px;
display: flex;
Expand Down Expand Up @@ -995,7 +1002,7 @@ class DatasourceEditor extends React.PureComponent {
</>
}
/>
<Tabs
<StyledTableTabs
fullWidth={false}
id="table-tabs"
data-test="edit-dataset-tabs"
Expand Down Expand Up @@ -1086,7 +1093,7 @@ class DatasourceEditor extends React.PureComponent {
</Col>
</div>
</Tabs.TabPane>
</Tabs>
</StyledTableTabs>
</DatasourceContainer>
);
}
Expand Down
4 changes: 4 additions & 0 deletions superset-frontend/src/datasource/DatasourceModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ const StyledDatasourceModal = styled(Modal)`
.modal-footer {
flex: 0 1 auto;
}

.ant-modal-body {
overflow: visible;
}
`;

interface DatasourceModalProps {
Expand Down