test: DisplayQueryButton #13750
Merged
test: DisplayQueryButton #13750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13750 +/- ##
==========================================
+ Coverage 77.45% 77.53% +0.07%
==========================================
Files 933 934 +1
Lines 47144 47249 +105
Branches 5848 5892 +44
==========================================
+ Hits 36516 36634 +118
+ Misses 10485 10471 -14
- Partials 143 144 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Show resolved
Hide resolved
geido
reviewed
Mar 24, 2021
Member
geido
left a comment
geido
left a comment
There was a problem hiding this comment.
LGTM apart from a small nit and what Michael has suggested
superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Show resolved
Hide resolved
superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Outdated
Show resolved
Hide resolved
…splayQueryButton.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…splayQueryButton.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
Contributor
Author
|
@rusackas can you look here please |
michael-s-molina
approved these changes
Mar 29, 2021
Member
|
/testenv up |
Contributor
|
@junlincc Ephemeral environment spinning up at http://52.36.47.201:8080. Credentials are |
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
amitmiran137
pushed a commit
that referenced
this pull request
Apr 2, 2021
* master: (26 commits) chore: bump to new superset-ui version (#13932) fix: do not run containers as root by default in Helm chart (#13917) feat(explore): adhoc column formatting for Table chart (#13758) fix(sqla-query): order by aggregations in Presto and Hive (#13739) feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894) test: Fixes PropertiesModal_spec (#13548) fix: Pin Prophet dependency after breaking changes (#13852) test: Adds tests to dnd controls (#13650) test: Adds tests to the AnnotationLayer component (#13748) test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799) Add tests (#13778) test: DisplayQueryButton (#13750) Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905) Revert "fix: select table overlay (#13694)" (#13901) test: Adds tests to the OptionControls component (#13729) test: DatasourceControl (#13605) tests for function handleScroll (#13896) test: Adds tests to the CustomFrame component (#13675) test: Adds tests to the AdvancedFrame component (#13664) test: DataTableControl (#13668) ...
lyndsiWilliams
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 7, 2021
* Tests for DisplayQueryButton component * add factories to props and fetch-mock * Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx Co-authored-by: Michael S. Molina <[email protected]> * Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Michael S. Molina <[email protected]>
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Tests for DisplayQueryButton component * add factories to props and fetch-mock * Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx Co-authored-by: Michael S. Molina <[email protected]> * Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Michael S. Molina <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tests for DisplayQueryButton