Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: DatasourcePanelDragWrapper #13627

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 15, 2021

SUMMARY

Tests for DatasourcePanelDragWrapper

  • Moved to own folder
  • Creating tests for the component

TEST PLAN

No behavior changes and the interface for importing was maintained.
All tests must pass.

@yardz yardz closed this Mar 15, 2021
@yardz yardz reopened this Mar 15, 2021
@yardz yardz closed this Mar 15, 2021
@yardz yardz reopened this Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #13627 (28981ae) into master (a35825d) will decrease coverage by 4.16%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13627      +/-   ##
==========================================
- Coverage   77.21%   73.04%   -4.17%     
==========================================
  Files         912      608     -304     
  Lines       46449    21638   -24811     
  Branches     5725     5723       -2     
==========================================
- Hits        35866    15806   -20060     
+ Misses      10447     5696    -4751     
  Partials      136      136              
Flag Coverage Δ
cypress 56.57% <100.00%> (+<0.01%) ⬆️
hive ?
javascript 63.07% <33.33%> (+0.03%) ⬆️
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/components/SupersetResourceSelect/index.tsx 90.32% <ø> (ø)
...tasourcePanel/DatasourcePanelDragWrapper/index.tsx 100.00% <ø> (ø)
...-frontend/src/explore/components/controls/index.js 100.00% <ø> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 56.00% <0.00%> (ø)
...perset-frontend/src/explore/components/Control.tsx 95.45% <100.00%> (+0.21%) ⬆️
superset-frontend/src/views/CRUD/hooks.ts 60.62% <100.00%> (ø)
superset/db_engine_specs/snowflake.py
superset/models/datasource_access_request.py
superset/reports/filters.py
superset/annotation_layers/commands/bulk_delete.py
... and 295 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35825d...0831a3a. Read the comment docs.

@junlincc junlincc requested a review from pkdotson March 15, 2021 23:07
@junlincc junlincc added the need:merge The PR is ready to be merged label Mar 17, 2021
@michael-s-molina
Copy link
Member

@yardz my PR #13650 is going to allow the {useDnd: true}, similar to {useRedux: true}. You can use that in the future 😉

@betodealmeida betodealmeida merged commit fd7c9eb into apache:master Mar 23, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* Tests for DatasourcePanelDragWrapper

* Absolute import path
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/M test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants