-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support to configure the default explorer viz #13610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13610 +/- ##
==========================================
+ Coverage 77.31% 77.40% +0.09%
==========================================
Files 911 934 +23
Lines 46378 47250 +872
Branches 5613 5798 +185
==========================================
+ Hits 35858 36575 +717
- Misses 10384 10531 +147
- Partials 136 144 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@cccs-jc thanks for the contribution! could you provide more details what this change is for, in PR description? thanks! |
We are building a custom visualization based on agGrid and would like this custom table to be the default visualization when a user starts a chart explorer. This also enables us to control the default row limit and whether to start in aggregation or raw query mode. |
@junlincc did that answer your question? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Shouldn't affect any existing features @junlincc. Just a config option for what viz is the default in the viz picker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea - a minor improvement proposal, other than that LGTM
@villebro Did the change you suggested. Renamed config to DEFAULT_VIZ_TYPE |
@cccs-jc LGTM, but you need to fix the linting error:
|
@villebro I'm not sure what the linter is complaining about. I check the line break in case it might be a windows line break. But looks good to me.. |
The issue is Prettier's formatting guidelines says the line is too long and wants it broken up. You can run |
It would be great to allow setting this per user profile! (another reason to add meta storage for user configs) |
* master: (56 commits) test: Adds tests and storybook to CertifiedIcon component (#13457) chore: Moves CheckboxIcons to Checkbox folder (#13459) chore: Removes Popover duplication (#13462) build(deps): bump elliptic from 6.5.3 to 6.5.4 in /docs (#13527) fix: allow spaces in DB names (#13800) chore: Update PR template for SIP-59 DB migrations process (#13855) Add CODEOWNERS (#13759) feat(alerts & reports): Easier to read execution logs (#13752) fix: Disallows negative options remaining (#13749) Fix broken link (#13861) fix(native-filters): add global async query support to native filters (#13837) Displays row limit warning with Alert component (#13854) fix(errors): Downgrade error on stop query to a warning (#13826) fix(alerts and reports): Unify timestamp format on execution log view (#13718) fix(sqllab): warning message when rows limited (#13841) chore: add success log whenever a connection is working (#13811) fix(native-filters): improve loading styles for filter component (#13794) chore: update change log with cherry-picks for release 1.1 (#13824) feat: added support to configure the default explorer viz (#13610) fix(#13734): Properly escape special characters in CSV output (#13735) ...
* added support to configure the default explorer viz * code review fix * lint Co-authored-by: cccs-jc <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>
Added support for configuring what the default visualization used by the chart explorer.