Skip to content

Fixed big number issue #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vera-liu merged 2 commits into from
Oct 15, 2016
Merged

Fixed big number issue #1355

vera-liu merged 2 commits into from
Oct 15, 2016

Conversation

@vera-liu
Copy link
Contributor

@vera-liu vera-liu commented Oct 15, 2016

Done:

  • somehow the filling color for big number was white..not sure why it didn't block for v1, changed to black filling color, both v1 and v2 work fine now
  • adding text anchor to center for big number

Before:
screen shot 2016-10-14 at 5 27 24 pm

After:
screen shot 2016-10-14 at 5 20 49 pm

@ascott

@mistercrunch
Copy link
Member

mistercrunch commented Oct 15, 2016

LGTM

@vera-liu vera-liu merged commit 2095095 into apache:master Oct 15, 2016
@vera-liu vera-liu deleted the vliu_big_number_viz branch November 1, 2016 19:01
@dpgaspar dpgaspar mentioned this pull request Apr 30, 2020
Merged
12 tasks
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@suddjian @zhaoyongjie
Revert "chore: isolate the one actual jquery dependency (apache#1339)" (
64dca43 
apache#1355)

This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@suddjian @zhaoyongjie
Revert "chore: isolate the one actual jquery dependency (apache#1339)" (
09ccca3 
apache#1355)

This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@suddjian @zhaoyongjie
Revert "chore: isolate the one actual jquery dependency (apache#1339)" (
248d479 
apache#1355)

This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@suddjian @zhaoyongjie
Revert "chore: isolate the one actual jquery dependency (apache#1339)" (
e1944cf 
apache#1355)

This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 First shipped in 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 First shipped in 0.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vera-liu @mistercrunch