refactor: convert controlUtils to TypeScript (2 of 2) #13520
Conversation
ktmud
force-pushed
the
ts-control-utils
branch
3 times, most recently
from
5ccc0d7 to
c313e2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #13520 +/- ##
==========================================
- Coverage 77.53% 73.82% -3.72%
==========================================
Files 904 602 -302
Lines 45986 21304 -24682
Branches 5552 5516 -36
==========================================
- Hits 35657 15728 -19929
+ Misses 10195 5442 -4753
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| ); | ||
| } | ||
|
|
||
| const getMemoizedControlConfig = memoizeOne( |
There was a problem hiding this comment.
Is this one just changing location?
There was a problem hiding this comment.
Yes, because ESLint complains function being used before definition.
| }); | ||
|
|
||
| it('find control as a control object', () => { | ||
| let controlItem = findControlItem( |
There was a problem hiding this comment.
Could we do let controlItem: CustomControlItem?
There was a problem hiding this comment.
Unfortunately no, because findControlItem may also return null or ReactElement. Using simple type declaration will throw an error:
mistercrunch
added
🏷️ bot
3 participants
SUMMARY
Converting remaining functions in
controlUtilsto TypeScript.Also updated
superset-ui/chart-controlstov0.17.17to bring in: apache-superset/superset-ui#998As a side effect, following changes in
superset-uiare also brought in:cc @zhaoyongjie @villebro
Related: #13401
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
No functional changes. CI should pass.
ADDITIONAL INFORMATION