Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Tests and Storybook entry for the IndeterminateCheckbox Component #13502

Merged
merged 9 commits into from
Apr 7, 2021
Merged

test: Tests and Storybook entry for the IndeterminateCheckbox Component #13502

merged 9 commits into from
Apr 7, 2021

Conversation

geido
Copy link
Member

@geido geido commented Mar 6, 2021

Adds the test cases and a storybook entry with controls for the IndeterminateCheckbox component, while moving it to its dedicated directory.

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #13502 (d90f382) into master (f06d534) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head d90f382 differs from pull request most recent head 6d58859. Consider uploading reports for the commit 6d58859 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13502      +/-   ##
==========================================
- Coverage   79.21%   79.21%   -0.01%     
==========================================
  Files         936      936              
  Lines       47408    47408              
  Branches     5940     5940              
==========================================
- Hits        37554    37553       -1     
- Misses       9727     9728       +1     
  Partials      127      127              
Flag Coverage Δ
cypress 56.04% <ø> (-0.01%) ⬇️
javascript 68.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/IndeterminateCheckbox/index.tsx 100.00% <ø> (ø)
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06d534...6d58859. Read the comment docs.

@geido
Copy link
Member Author

geido commented Mar 9, 2021

@junlincc @rusackas

@geido geido changed the title test: Tests and Storybook entry for the IndeterminateCheckbox Component #13501 test: Tests and Storybook entry for the IndeterminateCheckbox Component Mar 25, 2021
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG!

@pkdotson pkdotson merged commit 6c06866 into apache:master Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
…nt (apache#13502)

* Add tests for IndeterminateCheckbox

* Add storybook entry

* Fix linting issue

* Remove mocked icon

* Add jest.fn to mockedProps
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…nt (apache#13502)

* Add tests for IndeterminateCheckbox

* Add storybook entry

* Fix linting issue

* Remove mocked icon

* Add jest.fn to mockedProps
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants