Skip to content

Conversation

@thinkh
Copy link
Contributor

@thinkh thinkh commented Mar 4, 2021

SUMMARY

The correct spelling is Foundation. It is already correct in all other places of the footer.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Check the footer of the generated docs.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

The correct spelling is Foundation
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the catch!

@etr2460 etr2460 merged commit 09e5ea1 into apache:master Mar 4, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
The correct spelling is Foundation
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants