Skip to content

chore: disable drag metrics and columns in datasourcePanel #13450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhaoyongjie merged 1 commit into from
Mar 4, 2021
Merged

chore: disable drag metrics and columns in datasourcePanel #13450

zhaoyongjie merged 1 commit into from
Mar 4, 2021

Conversation

@zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Mar 4, 2021

SUMMARY

  • Disable drag metrics and columns in DatasourcePanel when DnD FF is false.
  • restructure DatasourcePanel

TEST PLAN

tested in my local environment

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie requested a review from ktmud March 4, 2021 03:32
ktmud
ktmud approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhaoyongjie zhaoyongjie merged commit ca27b00 into apache:master Mar 4, 2021
@junlincc junlincc added the explore:drag&drop Related to drag&drop in Explore label Mar 11, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@zhaoyongjie
chore: disable drag metrics and columns in datasourcePanel (apache#13450
64e4878 
)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktmud ktmud ktmud approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:drag&drop Related to drag&drop in Explore size/M 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhaoyongjie @ktmud @mistercrunch @junlincc