Skip to content

Conversation

@mayurnewase
Copy link
Contributor

@mayurnewase mayurnewase commented Mar 3, 2021

SUMMARY

This cleans up remaining code used for directed force chart which was recently migrated to Echart's graph chart in this PR

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

1.Remove all graphs from slices table and run superset load_examples and superset init.
It should load slices of viz_type graph_chart and not directed_force.
2.Run existing tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@mayurnewase mayurnewase changed the title changes added chore(): clean old directed force graph code Mar 3, 2021
@mayurnewase mayurnewase changed the title chore(): clean old directed force graph code chore: clean old directed force graph code Mar 3, 2021
@mayurnewase mayurnewase changed the title chore: clean old directed force graph code chore: clean remaining old directed force graph code Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #13431 (7680da6) into master (65cec18) will decrease coverage by 4.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13431      +/-   ##
==========================================
- Coverage   76.05%   71.59%   -4.46%     
==========================================
  Files         903      802     -101     
  Lines       45632    40595    -5037     
  Branches     5494     4147    -1347     
==========================================
- Hits        34704    29065    -5639     
- Misses      10766    11530     +764     
+ Partials      162        0     -162     
Flag Coverage Δ
cypress 57.99% <ø> (+9.38%) ⬆️
hive ?
javascript ?
mysql 80.32% <ø> (+0.01%) ⬆️
postgres 80.35% <ø> (+0.01%) ⬆️
presto 80.02% <ø> (+<0.01%) ⬆️
python 80.59% <ø> (-0.27%) ⬇️
sqlite 79.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/explore/components/controls/VizTypeControl.jsx 89.23% <ø> (-1.54%) ⬇️
superset/examples/energy.py 27.50% <ø> (ø)
superset/viz.py 56.01% <ø> (-0.28%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Pagination/Ellipsis.tsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/components/OmniContainer/Omnibar.tsx 0.00% <0.00%> (-100.00%) ⬇️
...frontend/src/components/ErrorMessage/IssueCode.tsx 0.00% <0.00%> (-100.00%) ⬇️
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 493 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cec18...9679c0f. Read the comment docs.

@mayurnewase
Copy link
Contributor Author

mayurnewase commented Mar 3, 2021

connection error in test test-presto-hive while creating table birth names doesn't seem to be related to this pr.
error below
E sqlalchemy.exc.OperationalError: (pyhive.exc.OperationalError) TExecuteStatementResp(status=TStatus(statusCode=3, infoMessages=['*org.apache.hive.service.cli.HiveSQLException:Error while processing statement: FAILED: Execution Error, return code 2 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask:17:16', 'org.apache.hive.service.cli.operation.Operation:toSQLException:Operation.java:380', 'org.apache.hive.service.cli.operation.SQLOperation:runQuery:SQLOperation.java:257', 'org.apache.hive.service.cli.operation.SQLOperation:runInternal:SQLOperation.java:293', 'org.apache.hive.service.cli.operation.Operation:run:Operation.java:320', 'org.apache.hive.service.cli.session.HiveSessionImpl:executeStatementInternal:HiveSessionImpl.java:530', 'org.apache.hive.service.cli.session.HiveSessionImpl:executeStatement:HiveSessionImpl.java:506', 'org.apache.hive.service.cli.CLIService:executeStatement:CLIService.java:280', 'org.apache.hive.service.cli.thrift.ThriftCLIService:ExecuteStatement:ThriftCLIService.java:531', 'org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement:getResult:TCLIService.java:1437', 'org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement:getResult:TCLIService.java:1422', 'org.apache.thrift.ProcessFunction:process:ProcessFunction.java:39', 'org.apache.thrift.TBaseProcessor:process:TBaseProcessor.java:39', 'org.apache.hive.service.auth.TSetIpAddressProcessor:process:TSetIpAddressProcessor.java:56', 'org.apache.thrift.server.TThreadPoolServer$WorkerProcess:run:TThreadPoolServer.java:286', 'java.util.concurrent.ThreadPoolExecutor:runWorker:ThreadPoolExecutor.java:1142', 'java.util.concurrent.ThreadPoolExecutor$Worker:run:ThreadPoolExecutor.java:617', 'java.lang.Thread:run:Thread.java:748'], sqlState='08S01', errorCode=2, errorMessage='Error while processing statement: FAILED: Execution Error, return code 2 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask'), operationHandle=None)

@villebro
Copy link
Member

villebro commented Mar 3, 2021

Restarted the test, let's see if it was just flaky

@villebro villebro merged commit 8b38d63 into apache:master Mar 3, 2021
@villebro villebro added the v1.1 label Mar 3, 2021
@mayurnewase mayurnewase deleted the graph-chart-cleanup branch March 3, 2021 11:55
betodealmeida pushed a commit to betodealmeida/incubator-superset that referenced this pull request Mar 19, 2021
@geido geido added explore Namespace | Anything related to Explore and removed viz:explore:graph labels Feb 9, 2022
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore Namespace | Anything related to Explore size/M v1.1 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants