Skip to content

fix: use semver for badge sort #13424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
betodealmeida merged 1 commit into from
Mar 3, 2021
Merged

fix: use semver for badge sort #13424

betodealmeida merged 1 commit into from
Mar 3, 2021

Conversation

@eschutho
Copy link
Member

@eschutho eschutho commented Mar 2, 2021 •
edited
Loading

SUMMARY

We want to show the latest release badge based on semver. Currently the badge shows v38.0.1 on the readme

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after:
Screenshot_3_2_21__1_55_PM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

betodealmeida
betodealmeida approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eschutho
Copy link
Member Author

eschutho commented Mar 2, 2021

🏷 ready-to-merge

@superset-github-bot superset-github-bot bot added the need:merge The PR is ready to be merged label Mar 2, 2021
@eschutho eschutho changed the title use semver for badge sort fix: use semver for badge sort Mar 3, 2021
@betodealmeida betodealmeida merged commit 026782e into apache:master Mar 3, 2021
@eschutho eschutho deleted the elizabeth/update-badge-version branch March 5, 2021 19:49
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@eschutho
use semver for badge sort (apache#13424)
c8db52c
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset-io size/XS 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eschutho @betodealmeida @mistercrunch