Skip to content

chore: Added rockset and firebird #13418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srinify merged 6 commits into from
Mar 3, 2021
Merged

chore: Added rockset and firebird #13418

srinify merged 6 commits into from
Mar 3, 2021

Conversation

@srinify
Copy link
Contributor

@srinify srinify commented Mar 2, 2021 •
edited
Loading

SUMMARY

  • Added URL routing from old alerts / reports page to new one
  • Edited page + connection string for SQL Server (now Microsoft SQL Server)
  • Added Rockset database page
  • Added Rockset logo to homepage of Superset site
  • Added Firebird database page
  • Added Trino logo to homepage of Superset site
  • Removed trailing comma in BigQuery
  • Changed behavior of top-left Superset corner so browser is routed to contextual homepage (instead of always superset.apache.org!)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-03-02 at 9 55 40 AM

Screen Shot 2021-03-02 at 9 55 22 AM

Screen Shot 2021-03-02 at 9 52 14 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

villebro
villebro approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkdotson
pkdotson approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG!

@srinify srinify changed the title docs/mar2/newdatabases chore: Added rockset and firebird Mar 2, 2021
@junlincc junlincc added the need:merge The PR is ready to be merged label Mar 2, 2021
@srinify srinify merged commit 26b75fa into apache:master Mar 3, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@srinify
chore: Added rockset and firebird (apache#13418)
f87dc38 
* added URL rerouting from old alerts & reports page to new one

* edited SQL Server, Rockset, db ordering, and link that Superset logo in left corner takes you to

* added Trino logo and firebird connection string and removed bigquery trailing comma

* added ROckset logo

* changed db list ordering for firebird

* tweaked presnetation of firebird connection string
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkdotson pkdotson pkdotson approved these changes

@villebro villebro villebro approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset-io 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srinify @pkdotson @villebro @mistercrunch @junlincc