Skip to content

test: Adds storybook to IconTooltip component #13415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rusackas merged 1 commit into from
Mar 3, 2021
Merged

test: Adds storybook to IconTooltip component #13415

rusackas merged 1 commit into from
Mar 3, 2021

Conversation

@michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Mar 2, 2021

SUMMARY

  • Adds storybook to IconTooltip component
  • Moves IconTooltip tests to component's folder

TEST PLAN

1 - Execute IconTooltip tests
2 - All tests should pass

@rusackas

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc requested review from pkdotson and rusackas March 2, 2021 17:28
pkdotson
pkdotson approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit c3e19b2 into apache:master Mar 3, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@michael-s-molina
test: Adds storybook to IconTooltip component (apache#13415)
9e16237
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rusackas rusackas rusackas approved these changes

@pkdotson pkdotson pkdotson approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michael-s-molina @rusackas @pkdotson @mistercrunch @junlincc