Skip to content

Conversation

@michael-s-molina
Copy link
Member

SUMMARY

  • Adds storybook to FormRow component
  • Moves FormRow tests to component's folder

TEST PLAN

1 - Execute FormRow tests
2 - All tests should pass

@rusackas

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #13407 (9b5f9cc) into master (f19a830) will decrease coverage by 3.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13407      +/-   ##
==========================================
- Coverage   76.33%   73.00%   -3.33%     
==========================================
  Files         900      600     -300     
  Lines       45596    21160   -24436     
  Branches     5491     5418      -73     
==========================================
- Hits        34804    15448   -19356     
+ Misses      10648     5585    -5063     
+ Partials      144      127      -17     
Flag Coverage Δ
cypress 57.94% <ø> (-0.85%) ⬇️
hive ?
javascript 62.72% <0.00%> (-0.04%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/FormRow/FormRow.stories.tsx 0.00% <0.00%> (ø)
superset-frontend/src/components/FormRow/index.jsx 92.30% <ø> (ø)
...erset-frontend/src/SqlLab/components/ResultSet.tsx 68.46% <0.00%> (-0.31%) ⬇️
superset/models/sql_lab.py
superset/examples/countries.py
...t/annotation_layers/annotations/commands/delete.py
superset/reports/notifications/base.py
superset/views/dashboard/mixin.py
superset/db_engine_specs/pinot.py
superset/connectors/sqla/models.py
... and 357 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19a830...f578421. Read the comment docs.

@rusackas rusackas merged commit 327e9b0 into apache:master Mar 3, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants