feat(viz): implement time picker on filter box

[zhaoyongjie]

SUMMARY

• move utils.ts and constants.ts to DateFilterControl.utils
• rename DateFilterControl.frame to DateFilterControl.components
• remove original DateFilterControl
• implement time picker on filter box

TEST PLAN

changed files/packages structure only.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #13377 (bb56099) into master (3c62069) will decrease coverage by 4.19%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master   #13377      +/-   ##
==========================================
- Coverage   77.09%   72.90%   -4.20%     
==========================================
  Files         898      598     -300     
  Lines       45711    21088   -24623     
  Branches     5495     5386     -109     
==========================================
- Hits        35241    15374   -19867     
+ Misses      10344     5588    -4756     
  Partials      126      126              

Flag	Coverage Δ
cypress	57.90% <100.00%> (+0.28%)	⬆️
hive	?
javascript	62.63% <71.42%> (+0.05%)	⬆️
mysql	?
postgres	?
presto	?
python	?
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ols/DateFilterControl/components/AdvancedFrame.tsx	53.84% <ø> (ø)
...trols/DateFilterControl/components/CustomFrame.tsx	42.00% <ø> (ø)
...teFilterControl/components/DateFunctionTooltip.tsx	100.00% <ø> (ø)
...nts/controls/DateFilterControl/components/index.ts	100.00% <ø> (ø)
...ents/controls/DateFilterControl/utils/constants.ts	100.00% <ø> (ø)
...nts/controls/DateFilterControl/utils/dateParser.ts	93.58% <ø> (ø)
...-frontend/src/explore/components/controls/index.js	100.00% <ø> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx	0.00% <0.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx	85.84% <100.00%> (ø)
...ols/DateFilterControl/components/CalendarFrame.tsx	84.61% <100.00%> (ø)
... and 307 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c62069...b88326b. Read the comment docs.

[villebro]

Here's FilterBox with the old component:

Here with the new one (probably needs a slight CSS tweak):

Also, should we just remove the old LegacyDateFilterControl, as I don't think it's really needed anymore after this?

[zhaoyongjie]

Here's FilterBox with the old component:

Here with the new one (probably needs a slight CSS tweak):

Also, should we just remove the old LegacyDateFilterControl, as I don't think it's really needed anymore after this?

OH, thanks Ville, good catch. I will check this issue.

I very much agree to remove the old components, but I am afraid whether there are other companies that still rely on the original components.

[villebro]

I very much agree to remove the old components, but I am afraid whether there are other companies that still rely on the original components.

I think it's ok to remove it, as I feel we've made a collective decision to replace the old time picker with the new one. Anyway, if someone really needs it they can go to a previous SHA and get the code from there 🙂

[zhaoyongjie]

I very much agree to remove the old components, but I am afraid whether there are other companies that still rely on the original components.

I think it's ok to remove it, as I feel we've made a collective decision to replace the old time picker with the new one. Anyway, if someone really needs it they can go to a previous SHA and get the code from there 🙂

OK. I remove these legacy codes in this PR.

[zhaoyongjie]

@villebro, I fixed the style issue.

[villebro]

LGTM! Btw, I'd change the title to feat(viz): implement time picker on filter box or something similar, as this is more a new feature for filter box than just a refactor.

[zhaoyongjie]

Thank you @villebro.
I totally agree with your suggestion