-
Notifications
You must be signed in to change notification settings - Fork 16.6k
chore: Migrating dashboard/components/menu from jsx to tsx #13361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
etr2460
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! A few comments about the types, and also I think you need to fix a conflict with the package-lock file
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/menu/BackgroundStyleDropdown.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/menu/MarkdownModeDropdown.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/menu/PopoverDropdown.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/menu/PopoverDropdown.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #13361 +/- ##
==========================================
+ Coverage 53.06% 57.93% +4.87%
==========================================
Files 489 503 +14
Lines 17314 16174 -1140
Branches 4482 4157 -325
==========================================
+ Hits 9187 9371 +184
+ Misses 8127 6803 -1324
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the iteration, this looks great now! Only one other item to address (adding a comment in the code), otherwise it lgtm
|
Thanks for the contribution! |
SUMMARY
Migrated files under
superset-frontend/dashboard/components/menufrom jsx to tsx.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before and After for MarkdownModeDropdown and PopoverDropdown
Before and After for BackgroundStyleDropdown and PopoverDropdown
TEST PLAN
ADDITIONAL INFORMATION