Skip to content

Conversation

@a5net
Copy link
Contributor

@a5net a5net commented Feb 26, 2021

SUMMARY

Migrated files under superset-frontend/dashboard/components/menu from jsx to tsx.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before and After for MarkdownModeDropdown and PopoverDropdown

Screen Shot 2021-02-26 at 20 03 21

Screen Shot 2021-02-26 at 19 27 28

Before and After for BackgroundStyleDropdown and PopoverDropdown

Screen Shot 2021-02-26 at 20 03 52

Screen Shot 2021-02-26 at 19 49 26

TEST PLAN

ADDITIONAL INFORMATION

@junlincc junlincc added new:contributor The author is a new contributor risk:migration High risk PR, wait for(at least) a week to deploy after merging dashboard:component Related to the drag&drop components of the Dashboard labels Feb 26, 2021
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! A few comments about the types, and also I think you need to fix a conflict with the package-lock file

@a5net a5net requested a review from etr2460 March 2, 2021 08:29
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #13361 (12ecfb7) into master (2ce7982) will increase coverage by 4.87%.
The diff coverage is 67.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13361      +/-   ##
==========================================
+ Coverage   53.06%   57.93%   +4.87%     
==========================================
  Files         489      503      +14     
  Lines       17314    16174    -1140     
  Branches     4482     4157     -325     
==========================================
+ Hits         9187     9371     +184     
+ Misses       8127     6803    -1324     
Flag Coverage Δ
cypress 57.93% <67.06%> (+4.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx 5.68% <0.00%> (+1.43%) ⬆️
...end/src/SqlLab/components/RunQueryActionButton.tsx 52.77% <ø> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.02% <ø> (-0.44%) ⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx 23.80% <ø> (ø)
superset-frontend/src/chart/ChartContainer.jsx 100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 74.66% <0.00%> (-2.05%) ⬇️
...perset-frontend/src/common/components/Dropdown.tsx 50.00% <ø> (ø)
...t-frontend/src/common/components/Tooltip/index.tsx 100.00% <ø> (ø)
...perset-frontend/src/components/AlteredSliceTag.jsx 92.00% <ø> (ø)
...ontend/src/components/CertifiedIconWithTooltip.tsx 0.00% <ø> (ø)
... and 337 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc2daf...12ecfb7. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iteration, this looks great now! Only one other item to address (adding a comment in the code), otherwise it lgtm

@a5net a5net requested a review from etr2460 March 4, 2021 09:01
@etr2460
Copy link
Member

etr2460 commented Mar 4, 2021

Thanks for the contribution!

@etr2460 etr2460 merged commit 483405f into apache:master Mar 4, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
)

* fix: constant icon size

* clean up

* dashboard/components/menu jsx -> tsx

* more types

* package-lock.json sync

* package-lock fix

* fix

* lint fix

* added comment about event type
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:component Related to the drag&drop components of the Dashboard new:contributor The author is a new contributor risk:migration High risk PR, wait for(at least) a week to deploy after merging size/L 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants