-
Notifications
You must be signed in to change notification settings - Fork 16.6k
test: Adds tests and storybook to CopyToClipboard component #13359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Adds tests and storybook to CopyToClipboard component #13359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13359 +/- ##
==========================================
- Coverage 77.04% 72.76% -4.29%
==========================================
Files 894 598 -296
Lines 45664 21277 -24387
Branches 5490 5423 -67
==========================================
- Hits 35184 15482 -19702
+ Misses 10356 5669 -4687
- Partials 124 126 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of inline styles if there's a better place to stick this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... at the very least, we could set up the css={theme => css... boilerplate to make it look like real CSS with theme support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to use the css property instead of style.
580f5dc to
abf526c
Compare
rusackas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
|
Thanks for the PR! |
SUMMARY
CopyToClipboardcomponentProvidersupport for storiesheighttype tostringinAsyncAceEditorstorydisabledtodisablein storiesTEST PLAN
1 - Execute
CopyToClipboardtests2 - All tests should pass
@rusackas @junlincc
ADDITIONAL INFORMATION