Skip to content

Conversation

@michael-s-molina
Copy link
Member

SUMMARY

  • Adds tests and storybook to CopyToClipboard component
  • Adds Redux Provider support for stories
  • Changes height type to string in AsyncAceEditor story
  • Changes parameter disabled to disable in stories

TEST PLAN

1 - Execute CopyToClipboard tests
2 - All tests should pass

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #13359 (0444931) into master (1e3130d) will decrease coverage by 4.28%.
The diff coverage is 74.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13359      +/-   ##
==========================================
- Coverage   77.04%   72.76%   -4.29%     
==========================================
  Files         894      598     -296     
  Lines       45664    21277   -24387     
  Branches     5490     5423      -67     
==========================================
- Hits        35184    15482   -19702     
+ Misses      10356     5669    -4687     
- Partials      124      126       +2     
Flag Coverage Δ
cypress 57.65% <68.54%> (+0.02%) ⬆️
hive ?
javascript 62.69% <57.83%> (+0.28%) ⬆️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/common/components/Collapse/Collapse.stories.tsx 0.00% <ø> (ø)
...set-frontend/src/common/components/Modal/Modal.tsx 100.00% <ø> (ø)
.../src/common/components/Tooltip/Tooltip.stories.tsx 0.00% <ø> (ø)
...et-frontend/src/components/Alert/Alert.stories.tsx 0.00% <ø> (ø)
...mponents/AsyncAceEditor/AsyncAceEditor.stories.tsx 0.00% <ø> (ø)
...-frontend/src/components/Button/Button.stories.tsx 85.00% <ø> (ø)
...src/components/ButtonGroup/ButtonGroup.stories.tsx 0.00% <ø> (ø)
...onents/CopyToClipboard/CopyToClipboard.stories.tsx 0.00% <0.00%> (ø)
...-frontend/src/components/CopyToClipboard/index.jsx 88.57% <ø> (ø)
...rontend/src/components/Loading/Loading.stories.tsx 0.00% <ø> (ø)
... and 333 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3130d...abf526c. Read the comment docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of inline styles if there's a better place to stick this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... at the very least, we could set up the css={theme => css... boilerplate to make it look like real CSS with theme support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to use the css property instead of style.

@michael-s-molina michael-s-molina force-pushed the tests-audit-copy-to-clipboard branch from 580f5dc to abf526c Compare March 1, 2021 16:24
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@junlincc junlincc requested a review from pkdotson March 1, 2021 22:57
@junlincc
Copy link
Member

junlincc commented Mar 1, 2021

Thanks for the PR!
@pkdotson Phillip, please take a second look, then ready to go:)

@rusackas rusackas merged commit e9d5d3b into apache:master Mar 3, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants