Skip to content

Conversation

@mistercrunch
Copy link
Member

No description provided.

@@ -0,0 +1,19 @@
px.registerViz('helloworld', function(slice) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? unrelated code?

@coleslaw
Copy link
Contributor

Left some comments, but LGTM 👍

@mistercrunch
Copy link
Member Author

Feature isn't complete yet, that was a first draft.

@rmessner
Copy link

I'm really interested in this feature.
How can I help to make it a feature ready to merge.

@sid88in
Copy link
Contributor

sid88in commented Apr 20, 2016

@mistercrunch any update on this?

@mistercrunch
Copy link
Member Author

Opting for #418 instead of this PR

@landscape-bot
Copy link

Code Health
Repository health decreased by 15% when pulling 86e354f on post_agg into 6e1413d on master.

@mistercrunch mistercrunch deleted the post_agg branch November 9, 2016 22:24
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Apr 1, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request Jul 9, 2019
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
* build: storybook 5

* feat: configure js/jsx storybook

* chore: modify storybook webpack config

* fix: type

* fix: packages.json dep order
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* build: storybook 5

* feat: configure js/jsx storybook

* chore: modify storybook webpack config

* fix: type

* fix: packages.json dep order
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* build: storybook 5

* feat: configure js/jsx storybook

* chore: modify storybook webpack config

* fix: type

* fix: packages.json dep order
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* build: storybook 5

* feat: configure js/jsx storybook

* chore: modify storybook webpack config

* fix: type

* fix: packages.json dep order
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* build: storybook 5

* feat: configure js/jsx storybook

* chore: modify storybook webpack config

* fix: type

* fix: packages.json dep order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants