refactor: add frontend debounce constants #13250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rusackas
approved these changes
Feb 20, 2021
Member
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
Love it! I was thinking about this yesterday. Stop reading my mind! LGTM!
ktmud
commented
Feb 20, 2021
| datasourceFilters.push( | ||
| <ControlRow | ||
| key="sqla-filters" | ||
| className="control-row" |
Member
Author
There was a problem hiding this comment.
Bycatch: this prop is not used in ControlRow.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add two debounce delay constants for: 1. fast UI updates; 2. expensive UI updates.
Using constants makes sure the experience is the same.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
No functional changes.
Some debounce delays may be slightly different.
TEST PLAN
CI should pass.
ADDITIONAL INFORMATION