fix(cross-filters): apply cross filters for all charts#13178
Merged
villebro merged 1 commit intoapache:masterfrom Feb 17, 2021
Merged
fix(cross-filters): apply cross filters for all charts#13178villebro merged 1 commit intoapache:masterfrom
villebro merged 1 commit intoapache:masterfrom
Conversation
junlincc
added
the
dashboard:native-filters
villebro
approved these changes
Feb 17, 2021
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM - Note to self, we need to implement similar NULL formatting in the Select component as we have in the table chart.
junlincc
added
dashboard:cross-filters
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR apply cross filter functionality for all charts on dashboard until will be implemented it's scoping
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-02-17.at.17.41.19.mov
TEST PLAN
ADDITIONAL INFORMATION