Skip to content

refactor: remove deprecated field from frontend usage #13142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suddjian merged 2 commits into from
Feb 17, 2021
Merged

refactor: remove deprecated field from frontend usage #13142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628bfa4
refactor: remove deprecated chart.edit_url field from frontend usage
suddjian Feb 15, 2021
5079ad9
Merge branch 'master' into refactor-chart-edit-url
suddjian Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions superset-frontend/spec/fixtures/mockSliceEntities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export const sliceEntitiesForChart = {
compare_suffix: 'o10Y',
datasource: datasourceId,
},
edit_url: `/chart/edit/${sliceId}`,
viz_type: 'pie',
datasource: datasourceId,
description: null,
Expand Down Expand Up @@ -78,7 +77,6 @@ export const sliceEntitiesForDashboard = {
},
],
},
edit_url: '/chart/edit/127',
viz_type: 'filter_box',
datasource: '2__table',
description: null,
Expand All @@ -91,7 +89,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20128%7D',
slice_name: "World's Population",
form_data: {},
edit_url: '/chart/edit/128',
viz_type: 'big_number',
datasource: '2__table',
description: null,
Expand All @@ -104,7 +101,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20129%7D',
slice_name: 'Most Populated Countries',
form_data: {},
edit_url: '/chart/edit/129',
viz_type: 'table',
datasource: '2__table',
description: null,
Expand All @@ -117,7 +113,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20130%7D',
slice_name: 'Growth Rate',
form_data: {},
edit_url: '/chart/edit/130',
viz_type: 'line',
datasource: '2__table',
description: null,
Expand All @@ -130,7 +125,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20131%7D',
slice_name: '% Rural',
form_data: {},
edit_url: '/chart/edit/131',
viz_type: 'world_map',
datasource: '2__table',
description: null,
Expand All @@ -143,7 +137,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20132%7D',
slice_name: 'Life Expectancy VS Rural %',
form_data: {},
edit_url: '/chart/edit/132',
viz_type: 'bubble',
datasource: '2__table',
description: null,
Expand All @@ -156,7 +149,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20133%7D',
slice_name: 'Rural Breakdown',
form_data: {},
edit_url: '/chart/edit/133',
viz_type: 'sunburst',
datasource: '2__table',
description: null,
Expand All @@ -169,7 +161,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20134%7D',
slice_name: "World's Pop Growth",
form_data: {},
edit_url: '/chart/edit/134',
viz_type: 'area',
datasource: '2__table',
description: null,
Expand All @@ -182,7 +173,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20135%7D',
slice_name: 'Box plot',
form_data: {},
edit_url: '/chart/edit/135',
viz_type: 'box_plot',
datasource: '2__table',
description: null,
Expand All @@ -195,7 +185,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20136%7D',
slice_name: 'Treemap',
form_data: {},
edit_url: '/chart/edit/136',
viz_type: 'treemap',
datasource: '2__table',
description: null,
Expand Down
2 changes: 0 additions & 2 deletions superset-frontend/src/dashboard/actions/sliceEntities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export function fetchAllSlices(userId) {
'datasource_name_text',
'description_markeddown',
'description',
'edit_url',
'id',
'params',
'slice_name',
Expand Down Expand Up @@ -87,7 +86,6 @@ export function fetchAllSlices(userId) {
slice_id: slice.id,
slice_url: slice.url,
slice_name: slice.slice_name,
edit_url: slice.edit_url,
form_data,
datasource_name: slice.datasource_name_text,
datasource_url: slice.datasource_url,
Expand Down
1 change: 0 additions & 1 deletion superset-frontend/src/dashboard/reducers/getInitialState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export default function getInitialState(bootstrapData) {
slice_url: slice.slice_url,
slice_name: slice.slice_name,
form_data: slice.form_data,
edit_url: slice.edit_url,
viz_type: slice.form_data.viz_type,
datasource: slice.form_data.datasource,
description: slice.description,
Expand Down
1 change: 0 additions & 1 deletion superset-frontend/src/dashboard/util/propShapes.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export const slicePropShape = PropTypes.shape({
slice_id: PropTypes.number.isRequired,
slice_url: PropTypes.string.isRequired,
slice_name: PropTypes.string.isRequired,
edit_url: PropTypes.string.isRequired,
datasource: PropTypes.string,
datasource_name: PropTypes.string,
datasource_link: PropTypes.string,
Expand Down