fix(viz): bump table viz to fix ordering bug#12930
Merged
ktmud merged 1 commit intoapache:masterfrom Feb 4, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12930 +/- ##
==========================================
- Coverage 68.98% 66.89% -2.09%
==========================================
Files 1025 489 -536
Lines 48765 28667 -20098
Branches 5188 0 -5188
==========================================
- Hits 33639 19178 -14461
+ Misses 14992 9489 -5503
+ Partials 134 0 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
sorts the data based on the first metric unless an order is set. ✅ Screen.Recording.2021-02-03.at.2.49.30.PM.mov@ktmud could you do a code review? thanks |
ktmud
approved these changes
Feb 4, 2021
Member
|
Obviously I merged this prematurely. E2E test is failing. Will push a fix soon. |
6 tasks
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
During a recent refactor the default behavior of table chart changed which requires explicitly stating the ordering of rows. This PR updates the table chart viz plugin to the newest version which sorts the data based on the first metric unless an order is set. See apache-superset/superset-ui#930 for screenshots and more details.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION