Skip to content

fix(viz): bump table viz to fix ordering bug#12930

Merged
ktmud merged 1 commit intoapache:masterfrom
preset-io:villebro/bump-table
Feb 4, 2021
Merged

fix(viz): bump table viz to fix ordering bug#12930
ktmud merged 1 commit intoapache:masterfrom
preset-io:villebro/bump-table

Conversation

@villebro
Copy link
Copy Markdown
Member

@villebro villebro commented Feb 3, 2021

SUMMARY

During a recent refactor the default behavior of table chart changed which requires explicitly stating the ordering of rows. This PR updates the table chart viz plugin to the newest version which sorts the data based on the first metric unless an order is set. See apache-superset/superset-ui#930 for screenshots and more details.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added viz:charts:table Related to the Table chart rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Feb 3, 2021
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #12930 (a19e47b) into master (b5b0c2c) will decrease coverage by 2.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12930      +/-   ##
==========================================
- Coverage   68.98%   66.89%   -2.09%     
==========================================
  Files        1025      489     -536     
  Lines       48765    28667   -20098     
  Branches     5188        0    -5188     
==========================================
- Hits        33639    19178   -14461     
+ Misses      14992     9489    -5503     
+ Partials      134        0     -134     
Flag Coverage Δ
cypress ?
javascript ?
python 66.89% <ø> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/connectors/sqla/models.py 84.51% <0.00%> (-5.91%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/databases/api.py 88.30% <0.00%> (-3.63%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/models/core.py 85.05% <0.00%> (-2.72%) ⬇️
superset/views/core.py 72.97% <0.00%> (-2.01%) ⬇️
... and 544 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b0c2c...a19e47b. Read the comment docs.

@junlincc
Copy link
Copy Markdown
Member

junlincc commented Feb 3, 2021

sorts the data based on the first metric unless an order is set. ✅

Screen.Recording.2021-02-03.at.2.49.30.PM.mov

@ktmud could you do a code review? thanks

@junlincc junlincc requested a review from ktmud February 3, 2021 22:51
@ktmud ktmud merged commit 86b982a into apache:master Feb 4, 2021
@ktmud
Copy link
Copy Markdown
Member

ktmud commented Feb 4, 2021

Obviously I merged this prematurely. E2E test is failing.

Will push a fix soon.

@villebro villebro deleted the villebro/bump-table branch February 4, 2021 19:05
villebro added a commit to preset-io/superset that referenced this pull request Feb 4, 2021
@junlincc junlincc removed #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels Mar 15, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS viz:charts:table Related to the Table chart 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants