Skip to content

Conversation

@villebro
Copy link
Member

@villebro villebro commented Feb 2, 2021

SUMMARY

This bumps PyArrow and Pandas to their respective latest versions (from 1.0.1 to 3.0.0 and 1.1.5 to 1.2.2 respectively). Also changes normalize_dttm_col to do in-place mutation of DataFrames to avoid unnecessary performance hit.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Feb 2, 2021

Codecov Report

Merging #12882 (f8b4ee8) into master (488da65) will decrease coverage by 5.55%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12882      +/-   ##
==========================================
- Coverage   77.25%   71.69%   -5.56%     
==========================================
  Files         899      802      -97     
  Lines       45541    40604    -4937     
  Branches     5461     4147    -1314     
==========================================
- Hits        35183    29113    -6070     
- Misses      10231    11491    +1260     
+ Partials      127        0     -127     
Flag Coverage Δ
cypress 57.95% <77.98%> (+0.04%) ⬆️
hive 79.97% <100.00%> (-0.01%) ⬇️
javascript ?
mysql 80.30% <100.00%> (-0.01%) ⬇️
postgres ?
presto 80.00% <100.00%> (-0.01%) ⬇️
python 80.78% <100.00%> (-0.08%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/ChartContainer.jsx 100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 74.66% <0.00%> (-2.37%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 82.47% <ø> (-4.13%) ⬇️
...s/nativeFilters/FilterBar/CascadeFilterControl.tsx 100.00% <ø> (+14.28%) ⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 80.85% <ø> (-12.01%) ⬇️
...perset-frontend/src/dashboard/containers/Chart.jsx 100.00% <ø> (ø)
...end/src/filters/components/Range/transformProps.ts 0.00% <0.00%> (ø)
...et-frontend/src/filters/components/Select/types.ts 100.00% <ø> (ø)
...tend/src/filters/components/Time/transformProps.ts 0.00% <0.00%> (ø)
...rset-frontend/src/filters/components/Time/types.ts 100.00% <ø> (ø)
... and 497 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488da65...ab6639e. Read the comment docs.

@villebro villebro force-pushed the villebro/bump-pyarrow-pandas branch from 42fc906 to df99651 Compare February 5, 2021 16:58
@villebro villebro force-pushed the villebro/bump-pyarrow-pandas branch from df99651 to a73551a Compare March 1, 2021 10:56
@villebro villebro changed the title [WIP] chore: bump pyarrow and pandas chore: bump pyarrow and pandas Mar 1, 2021
@villebro villebro force-pushed the villebro/bump-pyarrow-pandas branch from 2a26978 to d602759 Compare March 1, 2021 18:46
@villebro villebro force-pushed the villebro/bump-pyarrow-pandas branch from d602759 to 63ac3ca Compare March 1, 2021 18:50
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Mar 1, 2021
@villebro villebro force-pushed the villebro/bump-pyarrow-pandas branch from 63ac3ca to ab6639e Compare March 2, 2021 07:19
@villebro villebro requested a review from robdiciuccio March 2, 2021 08:32
@villebro villebro merged commit 70e12ed into apache:master Mar 2, 2021
@villebro villebro deleted the villebro/bump-pyarrow-pandas branch March 2, 2021 17:44
betodealmeida pushed a commit to betodealmeida/incubator-superset that referenced this pull request Mar 19, 2021
* bump pyarrow and pandas

* remove df copy
@villebro villebro added #bug:blocking! Blocking issues with high priority and removed #bug:blocking! Blocking issues with high priority labels Apr 6, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* bump pyarrow and pandas

* remove df copy
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 12, 2024
@mistercrunch mistercrunch added the 🚢 1.2.0 First shipped in 1.2.0 label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L v1.1 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants