Skip to content

Conversation

@kgabryje
Copy link
Member

SUMMARY

Disable confirming value with space button and replace it with tabulator and enter buttons - now we can use multi-word values like "Russian Federation".
Closes #12644
Fixes #12644

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Nagranie.z.ekranu.2021-01-25.o.09.51.49.mov

TEST PLAN

ADDITIONAL INFORMATION

CC: @junlincc @zuzana-vej @villebro

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #12730 (c50ec27) into master (307e3a9) will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12730      +/-   ##
==========================================
- Coverage   66.83%   66.41%   -0.42%     
==========================================
  Files        1022     1022              
  Lines       49992    49992              
  Branches     4892     5023     +131     
==========================================
- Hits        33410    33201     -209     
- Misses      16457    16666     +209     
  Partials      125      125              
Flag Coverage Δ
cypress 50.91% <ø> (ø)
javascript 60.87% <ø> (ø)
python 63.30% <ø> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Control/AdhocFilterEditPopoverSimpleTabContent.jsx 78.98% <ø> (ø)
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.69% <0.00%> (-24.88%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/db_engine_specs/base.py 79.59% <0.00%> (-6.38%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/db_engine_specs/presto.py 82.25% <0.00%> (-5.85%) ⬇️
superset/views/database/forms.py 83.33% <0.00%> (-5.56%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307e3a9...c50ec27. Read the comment docs.

@junlincc junlincc added explore:filter Related to filters in Explore v1.0.1bash! labels Jan 25, 2021
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Screen.Recording.2021-01-25.at.2.50.49.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:filter Related to filters in Explore size/XS v1.0.1 🍒 1.0.1 Cherry-picked to 1.0.1 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[explore] Unable to add space-separated values to filters using IN

6 participants