Skip to content

Conversation

@betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Jan 22, 2021

This reverts commit f354bb3.

The change in #12351 makes the examples data to be loaded into the main database instead of the examples database.

@dpgaspar let's discuss a way of not creating the unnecessary connection?

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title Revert "fix(load examples): load examples creating unnecessary main d… fix(load examples): revert #12351 Jan 22, 2021
@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #12701 (7600f6e) into master (7e77975) will decrease coverage by 3.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12701      +/-   ##
==========================================
- Coverage   66.93%   63.85%   -3.09%     
==========================================
  Files        1019      487     -532     
  Lines       49824    30014   -19810     
  Branches     4877        0    -4877     
==========================================
- Hits        33350    19164   -14186     
+ Misses      16351    10850    -5501     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress ?
javascript ?
python 63.85% <50.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/commands/importers/v1/utils.py 55.55% <50.00%> (ø)
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.86% <0.00%> (-2.99%) ⬇️
superset/views/core.py 72.82% <0.00%> (-2.48%) ⬇️
superset/db_engine_specs/mysql.py 89.79% <0.00%> (-2.05%) ⬇️
... and 542 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e77975...7600f6e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants