Skip to content

fix: Select options overflowing Save chart modal on Explore view #12522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
villebro merged 2 commits into from
Jan 15, 2021
Merged

fix: Select options overflowing Save chart modal on Explore view #12522

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64b88d
Fix select options overflowing modal
kgabryje Jan 14, 2021
b9f8609
fix unit test
villebro Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions superset-frontend/src/explore/components/SaveModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/* eslint camelcase: 0 */
import React from 'react';
import { Alert, FormControl, FormGroup, Radio } from 'react-bootstrap';
import { JsonObject, t } from '@superset-ui/core';
import { JsonObject, t, styled } from '@superset-ui/core';
import ReactMarkdown from 'react-markdown';
import Modal from 'src/common/components/Modal';
import Button from 'src/components/Button';
Expand Down Expand Up @@ -55,6 +55,12 @@ type SaveModalState = {
action: ActionType;
};

const StyledModal = styled(Modal)`
.ant-modal-body {
overflow: visible;
}
`;

class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
constructor(props: SaveModalProps) {
super(props);
Expand Down Expand Up @@ -153,7 +159,7 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {

render() {
return (
<Modal
<StyledModal
show
onHide={this.props.onHide}
title={t('Save Chart')}
Expand Down Expand Up @@ -261,7 +267,7 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
/>
</FormGroup>
</div>
</Modal>
</StyledModal>
);
}
}
Expand Down