Skip to content

Conversation

@junlincc
Copy link
Member

@junlincc junlincc commented Jan 12, 2021

SUMMARY

this pr is to FIX table header in Explore Data section
closes #12430

BEFORE

ezgif-7-7d0019f43dd3

AFTER

ezgif-3-59346b87046c

cc @kgabryje @ktmud

TEST PLAN

  1. open Explore in Chrome
  2. use wb_health_population as the dataset
  3. open Data section
  4. see both tables scroll with header fixed!

ADDITIONAL INFORMATION

  • [x ] Has associated issue: #12430
  • [x ] Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai
Copy link
Member

nytai commented Jan 12, 2021

👀 you're opening PRs now?! 👏

Can you confirm this hasn't affected the other list views, they're using the same table component.

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #12432 (a7e198e) into master (9b0e6d0) will decrease coverage by 3.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12432      +/-   ##
==========================================
- Coverage   66.81%   63.51%   -3.30%     
==========================================
  Files        1015      486     -529     
  Lines       49538    29895   -19643     
  Branches     5079        0    -5079     
==========================================
- Hits        33097    18988   -14109     
+ Misses      16311    10907    -5404     
+ Partials      130        0     -130     
Flag Coverage Δ
cypress ?
javascript ?
python 63.51% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/db_engine_specs/presto.py 70.56% <0.00%> (-11.48%) ⬇️
superset/db_engine_specs/postgres.py 82.45% <0.00%> (-3.51%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️
superset/views/base_api.py 97.68% <0.00%> (-0.47%) ⬇️
superset/reports/notifications/base.py 95.00% <0.00%> (-0.46%) ⬇️
... and 535 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0e6d0...a7e198e. Read the comment docs.

@junlincc
Copy link
Member Author

junlincc commented Jan 12, 2021

👀 you're opening PRs now?! 👏

Can you confirm this hasn't affected the other list views, they're using the same table component.

yup 3rd already, check out the other two one line change(with 5 commits) PRs 😅🤦🏾‍♀️ #12402 #12392
i just took a look at list view, they look normal. can you review and test? @nytai

@junlincc junlincc requested a review from robdiciuccio January 12, 2021 03:01
@nytai
Copy link
Member

nytai commented Jan 12, 2021

Code looks fine 😄 . I have a bunch of other stuff running at the moment and it's hard to switch over to superset, but I'll test once i'm done with my current setup

@adam-stasiak
Copy link
Contributor

Tested it is ok. I found an issue with scrolling on Safari but not related to this change. I will raise it in another issue :)

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suddjian suddjian merged commit fe01e2d into apache:master Jan 12, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[explore]table header in Explore Data is not fixed in Chrome

7 participants