Added tests

[vera-liu]

Done:

• component tests for default control panels
• test for fetch datasource metadata endpoint
• update tests for action creators

Todo:

• tests for ajax call in action creators

help-needed @ascott

[vera-liu]

I'm having trouble figuring this one out. I looked at multiple docs for testing ajax action creators, sinon fakeServer, nock etc. I think http://redux.js.org/docs/recipes/WritingTests.html seems to make more sense. I kind of modified some of it, but this test keeps failing. Saying the actual callCount of dispatch is 1 instead of 5. I figure the dispatch callcount may not take callbacks into account. Still trying to figure this out.

[ascott]

what if we test that the expected actions were called and not how many times dispatch was called? it looks like that's what the example is doing:

nock('http://example.com/')
      .get('/todos')
      .reply(200, { body: { todos: ['do something'] }})

    const expectedActions = [
      { type: types.FETCH_TODOS_REQUEST },
      { type: types.FETCH_TODOS_SUCCESS, body: { todos: ['do something']  } }
    ]
    const store = mockStore({ todos: [] })

    return store.dispatch(actions.fetchTodos())
      .then(() => { // return of async actions
        expect(store.getActions()).toEqual(expectedActions)
      })
  })

const expectedActions = [
  { type: types.SET_TIME_COLUMN_OPTS },
  { type: types.SET_TIME_GRAIN_OPTS },
  {...},
]

[vera-liu]

I tried it but it says 'Cannot read property 'then' of undefined'. It seems that the ajax call never returned.

[vera-liu]

I tried it but it didn't work, it says 'then' can't be called on undefined. I think somehow the ajax request never returned on the nock

[ascott]

here's an example spec that tests fetching from an API that the redux best practices doc references...
https://git.musta.ch/airbnb/airbnb/pull/44253/files#diff-1e402f9922b2b08b8ef90a58502d4c6bR56

maybe we can use that pattern?

[ascott]

asking in #frontend-goalie might be helpful too...

[vera-liu]

Sorry forgot to add this for last PR, adding it here

[mistercrunch]

Build is failing, conflicts, imprecise commit message. I'm closing, you can re-open if needed when ready.