Skip to content

fix(explore): flaky Change dataset modal #12390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
villebro merged 1 commit into from
Jan 9, 2021
Merged

fix(explore): flaky Change dataset modal #12390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions superset-frontend/src/datasource/ChangeDatasourceModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,20 +118,24 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
setConfirmedDataset(datasource);
}, []);

useDebouncedEffect(() => {
if (filter) {
fetchData({
...emptyRequest,
filters: [
{
id: 'table_name',
operator: 'ct',
value: filter,
},
],
});
}
}, 1000);
useDebouncedEffect(
() => {
if (filter) {
fetchData({
...emptyRequest,
filters: [
{
id: 'table_name',
operator: 'ct',
value: filter,
},
],
});
}
},
1000,
[filter],
);

useEffect(() => {
const onEnterModal = async () => {
Expand Down
5 changes: 3 additions & 2 deletions superset-frontend/src/explore/exploreUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,9 @@ export const exploreChart = formData => {
postForm(url, formData);
};

export const useDebouncedEffect = (effect, delay) => {
const callback = useCallback(effect, [effect]);
export const useDebouncedEffect = (effect, delay, deps) => {
// eslint-disable-next-line react-hooks/exhaustive-deps
const callback = useCallback(effect, deps);

useEffect(() => {
const handler = setTimeout(() => {
Expand Down