Skip to content

fix(load examples): load examples creating unnecessary main database #12351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpgaspar merged 2 commits into from
Jan 8, 2021
Merged

fix(load examples): load examples creating unnecessary main database #12351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15240d4
fix(load examples): load examples creating unnecessary main database …
dpgaspar Jan 8, 2021
34e83f8
fix lint
dpgaspar Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset/datasets/commands/importers/v1/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

from superset.connectors.sqla.models import SqlaTable
from superset.models.core import Database
from superset.utils.core import get_example_database, get_main_database
from superset.utils.core import get_example_database

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -136,7 +136,7 @@ def load_data(
df[column_name] = pd.to_datetime(df[column_name])

# reuse session when loading data if possible, to make import atomic
if example_database.sqlalchemy_uri == get_main_database().sqlalchemy_uri:
if example_database.sqlalchemy_uri == get_example_database().sqlalchemy_uri:
Copy link
Member

@betodealmeida betodealmeida Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpgaspar this condition will always be true, and causes the example data to be loaded into the main database instead of the examples databases (because it always reuses session.connection().

logger.info("Loading data inside the import transaction")
connection = session.connection()
else:
Expand Down