fix(explore): bump superset-ui to 0.16.3 and fix DeckGL bug #12242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simcha90
approved these changes
Jan 4, 2021
villebro
force-pushed
the
villebro/bump-queries-data
branch
from
859f3da to
23a7298
Compare
villebro
force-pushed
the
villebro/bump-queries-data
branch
from
23a7298 to
6e226a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #12242 +/- ##
==========================================
- Coverage 67.11% 59.57% -7.55%
==========================================
Files 996 946 -50
Lines 49176 46572 -2604
Branches 4993 4299 -694
==========================================
- Hits 33006 27746 -5260
- Misses 16047 18826 +2779
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
approved these changes
Jan 5, 2021
Member
junlincc
left a comment
junlincc
left a comment
There was a problem hiding this comment.
Approving it as the actual changes have been done in superset-ui
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR pulls in a few fixes related to the
0.16version ofsuperset-uiand fixes a bug in the DeckGL viz plugins:@superset-ui/coreversion0.16.3to bring in removal of the singularqueryDataproperty (see chore(core): remove queryData and replace with queriesData apache-superset/superset-ui#874 by @simchanielsen) and a fix to NVD3 and histogram chart control panels (fix: fix nvd3 and histogram regressions and migrate control panels to TS apache-superset/superset-ui#875).@superset-ui/legacy-preset-chart-deckglto 0.4.0 to pull in changes required bysuperset-ui0.16 version (see chore: bump superset-ui and update references to queriesData apache-superset/superset-ui-plugins-deckgl#22).BEFORE
DeckGL charts weren't ordered by the main metric, causing data to often be ordered by either lon/lat.
AFTER
After adding the original ordering prior to #11153 , DeckGL charts look normal again.
ADDITIONAL INFORMATION