Skip to content

[Easy] Remove duplicate code for property name of SqlaTable #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mistercrunch merged 1 commit into from
Sep 25, 2016
Merged

[Easy] Remove duplicate code for property name of SqlaTable #1190

mistercrunch merged 1 commit into from
Sep 25, 2016

Conversation

@prokh
Copy link
Contributor

@prokh prokh commented Sep 24, 2016

The code
@property def name(self): return self.table_name

is duplicated in the class SqlaTable.

First simple pull request to test the water in this project.

@xrmx
Copy link
Contributor

xrmx commented Sep 24, 2016

LGTM

@mistercrunch
Copy link
Member

mistercrunch commented Sep 25, 2016

good catch!

@mistercrunch mistercrunch merged commit 44be42c into apache:master Sep 25, 2016
This was referenced Feb 1, 2022
Open
Open
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Closed
@terrorizer1980 terrorizer1980 mentioned this pull request Jun 22, 2022
Closed
This was referenced Sep 27, 2022
Open
Open
This was referenced Oct 6, 2022
Open
Open
Open
Open
@terrorizer1980 terrorizer1980 mentioned this pull request May 24, 2023
Closed
@lili2311 lili2311 mentioned this pull request Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jul 4, 2023
Closed
@mariasnyk mariasnyk mentioned this pull request Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jul 5, 2023
Closed
@xiezhongfu xiezhongfu mentioned this pull request Jul 5, 2023
Open
@xiezhongfu xiezhongfu mentioned this pull request Nov 26, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 29, 2023
Closed
@lili2311 lili2311 mentioned this pull request Nov 29, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 30, 2023
Closed
@xiezhongfu xiezhongfu mentioned this pull request Dec 19, 2023
Open
This was referenced Dec 19, 2023
Closed
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0 labels Feb 19, 2024
This was referenced Apr 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prokh @xrmx @mistercrunch