Skip to content

fix: Remove "required" from SaveModal Add to dashboard field#11693

Merged
ktmud merged 1 commit intoapache:masterfrom
kgabryje:fix/savemodal-required
Nov 16, 2020
Merged

fix: Remove "required" from SaveModal Add to dashboard field#11693
ktmud merged 1 commit intoapache:masterfrom
kgabryje:fix/savemodal-required

Conversation

@kgabryje
Copy link
Copy Markdown
Member

SUMMARY

Remove an asterisk from SaveModal, which indicated that Add to dashboard field is required.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

ADDITIONAL INFORMATION

CC: @ktmud

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 13, 2020

Codecov Report

Merging #11693 (af773c1) into master (2f036e9) will increase coverage by 4.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11693      +/-   ##
==========================================
+ Coverage   62.85%   66.98%   +4.12%     
==========================================
  Files         889      889              
  Lines       43053    43061       +8     
  Branches     4015     4015              
==========================================
+ Hits        27063    28844    +1781     
+ Misses      15812    14115    -1697     
+ Partials      178      102      -76     
Flag Coverage Δ
cypress 56.09% <ø> (?)
javascript 62.82% <ø> (ø)
python 62.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/explore/components/SaveModal.jsx 95.58% <ø> (+4.41%) ⬆️
...et-frontend/src/SqlLab/components/LimitControl.tsx 89.36% <0.00%> (-1.95%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 74.24% <0.00%> (-1.15%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 77.17% <0.00%> (-0.85%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 73.03% <0.00%> (-0.83%) ⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 58.62% <0.00%> (-0.69%) ⬇️
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 66.14% <0.00%> (-0.53%) ⬇️
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <0.00%> (ø)
superset-frontend/src/views/CRUD/utils.tsx 50.00% <0.00%> (+1.21%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 60.75% <0.00%> (+1.26%) ⬆️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f036e9...af773c1. Read the comment docs.

@rusackas
Copy link
Copy Markdown
Member

@kgabryje a rebase will likely fix the failing cypress flakage.

@kgabryje kgabryje force-pushed the fix/savemodal-required branch from e147081 to af773c1 Compare November 16, 2020 09:07
@ktmud ktmud merged commit 3e6bcbb into apache:master Nov 16, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants