fix: Remove "required" from SaveModal Add to dashboard field#11693
Merged
ktmud merged 1 commit intoapache:masterfrom Nov 16, 2020
Merged
fix: Remove "required" from SaveModal Add to dashboard field#11693ktmud merged 1 commit intoapache:masterfrom
ktmud merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11693 +/- ##
==========================================
+ Coverage 62.85% 66.98% +4.12%
==========================================
Files 889 889
Lines 43053 43061 +8
Branches 4015 4015
==========================================
+ Hits 27063 28844 +1781
+ Misses 15812 14115 -1697
+ Partials 178 102 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
approved these changes
Nov 13, 2020
Member
|
@kgabryje a rebase will likely fix the failing cypress flakage. |
e147081 to
af773c1
Compare
ktmud
approved these changes
Nov 16, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove an asterisk from SaveModal, which indicated that Add to dashboard field is required.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
CC: @ktmud