fix: "Select all" option in SelectControl on Explore view#11692
Merged
graceguo-supercat merged 1 commit intoapache:masterfrom Nov 17, 2020
Merged
fix: "Select all" option in SelectControl on Explore view#11692graceguo-supercat merged 1 commit intoapache:masterfrom
graceguo-supercat merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11692 +/- ##
==========================================
- Coverage 62.85% 56.00% -6.86%
==========================================
Files 889 408 -481
Lines 43053 14437 -28616
Branches 4015 3716 -299
==========================================
- Hits 27063 8085 -18978
+ Misses 15812 6352 -9460
+ Partials 178 0 -178
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fb5a9cc to
23ae7cc
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
On Explore view, "Select all" option on select controls did not work.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Go to Explore, select a Table chart, click Group by -> select all.
ADDITIONAL INFORMATION
CC: @graceguo-supercat @junlincc @rusackas