fix: database connection validation when creation

[ktmud]

SUMMARY

Better database connection validation when creating a database. Discovered this bug while developing #11509 , the symptom of the failed test on the user side is you can add databases with wrong passwords as long as TABLE_NAMES_CACHE_CONFIG is enabled. The cause is that Database.get_all_schema_names is a cached function with self.id as cache key, but a newly created uncommitted Database instance always has self.id == None.

Also renames a couple of test databases to make it easier to debug in case some of them slip through failed tests and got incorrectly created.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

To reproduce the bug with unit tests:

1. Add TABLE_NAMES_CACHE_CONFIG in test config. E.g.

   TABLE_NAMES_CACHE_CONFIG = {
     **CACHE_CONFIG,
     "CACHE_KEY_PREFIX": "superset_data_cache",
   }
   

2. Run test case

   pytest tests/databases/api_tests.py::TestDatabaseApi::test_create_database_conn_fail
   

   multiple times
3. You test will fail with AssertionError: 201 != 422

To reproduce the bug in user interface:

1. Enable TABLE_NAMES_CACHE_CONFIG
2. Try adding a database with wrong password multiple times.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

cc @dpgaspar @john-bodley

[codecov-io]

Codecov Report

Merging #11653 (be2ce74) into master (a9f9c4b) will decrease coverage by 3.88%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11653      +/-   ##
==========================================
- Coverage   65.76%   61.87%   -3.89%     
==========================================
  Files         873      873              
  Lines       42316    42310       -6     
  Branches     3972     3972              
==========================================
- Hits        27827    26180    -1647     
- Misses      14374    15950    +1576     
- Partials      115      180      +65     

Flag	Coverage Δ
cypress	?
javascript	62.84% <ø> (ø)
python	61.28% <100.00%> (-0.64%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/databases/commands/create.py	91.83% <100.00%> (+0.34%)	⬆️
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupFormatters.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
... and 164 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f9c4b...be2ce74. Read the comment docs.

[john-bodley]

@dpgaspar would you mind taking a look at this as it changes some of the logic related to your API refactor?