feat: new report schedule models #11550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11550 +/- ##
==========================================
- Coverage 59.59% 59.26% -0.34%
==========================================
Files 832 834 +2
Lines 40482 40581 +99
Branches 3666 3666
==========================================
- Hits 24126 24051 -75
- Misses 16187 16361 +174
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
reviewed
Nov 4, 2020
mistercrunch
reviewed
Nov 4, 2020
mistercrunch
reviewed
Nov 4, 2020
dpgaspar
commented
Nov 5, 2020
willbarrett
approved these changes
Nov 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* feat: new report schedule models * lint and unique constraint * support sqlite * fix sqlite * add audit mixin and minor fixes * fix FK's * address comments * lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
First PR (out of 3 on backend) for alerts and reports revamp, our main goals are: simplify and support future improvements/extensions.
This work will proceed on a side by side fashion until it will be considered complete and stable, then the current implementation will be removed from the codebase.
(Team work with @willbarrett and @mistercrunch)
Following PR's on the backend:
1 - REST API and business logic
2 - Celery tasks revamp
ADDITIONAL INFORMATION