Skip to content

Conversation

@nytai
Copy link
Member

@nytai nytai commented Oct 26, 2020

SUMMARY

the github action we're using to lint PR titles has a feature that adds PR reviews (as comments). Due to github permissions, this only works for PRs created from this repo (and not forks). We should disabled this feature as it provides an inconsistent experience and introduces some flakiness in the run (see https://github.com/apache/incubator-superset/pull/11371/checks?check_run_id=1310147435).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #11433 into master will decrease coverage by 9.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11433      +/-   ##
==========================================
- Coverage   66.55%   56.92%   -9.63%     
==========================================
  Files         860      408     -452     
  Lines       40866    13656   -27210     
  Branches     3694     3480     -214     
==========================================
- Hits        27198     7774   -19424     
+ Misses      13570     5720    -7850     
- Partials       98      162      +64     
Flag Coverage Δ
#cypress 56.92% <ø> (+0.35%) ⬆️
#javascript ?
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rset-frontend/src/profile/components/Favorites.tsx 0.00% <0.00%> (-86.67%) ⬇️
... and 683 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a54b5...1be4f8d. Read the comment docs.

@nytai nytai merged commit 8a2ca84 into apache:master Oct 26, 2020
@nytai nytai deleted the tai/fix-pr-lint-2 branch October 26, 2020 23:32
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants