Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): specify 'time_range_endpoints' to prevent toast warning #11417

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

mistercrunch
Copy link
Member

SUMMARY

Prevent this error message/toast on examples charts:
Screen Shot 2020-10-24 at 9 13 27 PM

SIP-15 #6360 introduced new internal chart params that never got fixed in our examples, and the error message above have been showing up ever since. This PR addresses the error message by adding the required chart parameters to the examples as they get loaded.

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #11417 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11417   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files         860      860           
  Lines       40871    40871           
  Branches     3688     3688           
=======================================
+ Hits        27201    27203    +2     
+ Misses      13571    13570    -1     
+ Partials       99       98    -1     
Flag Coverage Δ
#cypress 56.60% <ø> (+0.05%) ⬆️
#javascript 62.92% <ø> (ø)
#python 61.92% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/birth_names.py 100.00% <ø> (ø)
superset/examples/deck.py 13.84% <ø> (ø)
superset/examples/world_bank.py 100.00% <ø> (ø)
superset/views/utils.py 81.77% <0.00%> (-0.43%) ⬇️
superset/views/core.py 74.30% <0.00%> (-0.17%) ⬇️
superset/connectors/sqla/models.py 89.62% <0.00%> (-0.14%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 84.69% <0.00%> (+1.02%) ⬆️
superset-frontend/src/SqlLab/actions/sqlLab.js 65.59% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02a61f...d22cf33. Read the comment docs.

@mistercrunch mistercrunch merged commit 10a54b5 into apache:master Oct 26, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants